All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Sven Wegener <sven.wegener@stealer.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] Change default KERNEL_DIR location and add KBUILD_OUTPUT
Date: Sun, 15 Jul 2007 17:33:50 +0200	[thread overview]
Message-ID: <469A3E5E.2010507@trash.net> (raw)
In-Reply-To: <20070715153145.GA24365@titan.stealer.net>

Sven Wegener wrote:
> On Sun, Jul 15, 2007 at 04:34:24PM +0200, Patrick McHardy wrote:
> 
>>What do we need KBUILD_OUTPUT for? Just the source tree should be enough.
> 
> 
> For current kernels, true. Older kernels (before 2006-04-26) and the
> whole 2.6.16.y series have a bug where include/linux/netfilter_ipv4.h
> includes linux/config.h which includes linux/autoconf.h which is placed
> into KBUILD_OUTPUT. Just changing KERNEL_DIR from build to source should
> be enough for recent kernels. For older kernels building the iptables
> package will fail with "linux/autoconf.h: No such file or directory"
> unless we add the KBUILD_OUTPUT bit. That's why I added it. Do we want
> to have this workaround here?


I don't see why not. A short comment in the Makefile explaining the
situation would be nice though.

  reply	other threads:[~2007-07-15 15:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-14 20:15 [PATCH] Change default KERNEL_DIR location and add KBUILD_OUTPUT Sven Wegener
2007-07-15 14:34 ` Patrick McHardy
2007-07-15 15:31   ` Sven Wegener
2007-07-15 15:33     ` Patrick McHardy [this message]
2007-07-15 16:01       ` Sven Wegener
2007-07-15 16:03         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469A3E5E.2010507@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=sven.wegener@stealer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.