All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gleb O. Raiko" <raiko@niisi.msk.ru>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Sergey Rogozhkin <rogozhkin@niisi.msk.ru>,
	kumba@gentoo.org, linux-mips@linux-mips.org
Subject: Re: O2 RM7000 Issues
Date: Tue, 17 Jul 2007 11:54:36 +0400	[thread overview]
Message-ID: <469C75BC.5040501@niisi.msk.ru> (raw)
In-Reply-To: <20070716123343.GA13439@linux-mips.org>

Ralf,

Considering RM7k the latest kernel improperly sets some hazards. At 
least, mtc0_tlbw_hazard and tlbw_use_hazard shall contain 4 nops, not 2.

Also, there shall be 10 nops after modification of the K0 field of the 
config register. The suspicious place I see is in 
arch/mips/mm/c-r4k.c:coherency_setup():
	change_c0_config(CONF_CM_CMASK, CONF_CM_DEFAULT);

If the K0 field has the value different than CONF_CM_DEFAULT, we 
definitely need nops here and, I'm afraid, even the line shall be 
executed uncached.

Strictly speaking, manual doesn't clearly define the term 
"modification". I expect, if I write the same value in the K0 field, it 
doesn't consider "modification".

And I guess all boards with RM7k select DMA_NONCOHERENT. Otherwise, 
CONF_CM_DEFAULT will have a garbage in case of RM7k. Perhaps, it's worth
to select DMA_NONCOHERENT inside the "config CPU_RM7000" block.

Regards,
Gleb.

  parent reply	other threads:[~2007-07-17  7:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-01 16:57 O2 RM7000 Issues Kumba
2007-07-01 22:07 ` freshy98
2007-07-02 13:08   ` sknauert
2007-07-02 13:08   ` sknauert
2007-07-04 15:27     ` Ralf Baechle
2007-07-04 19:22       ` Ralf Baechle
2007-07-16 11:53         ` Sergey Rogozhkin
2007-07-16 12:33           ` Ralf Baechle
2007-07-16 17:38             ` Andrew Sharp
2007-07-17 14:01               ` Kumba
2007-07-19 18:58                 ` Andrew Sharp
2007-07-19 22:26                   ` Shane McDonald
2007-07-17  7:54             ` Gleb O. Raiko [this message]
2007-07-17  9:04         ` Sergey Rogozhkin
2007-07-17 10:14           ` Ralf Baechle
2007-07-17 12:27           ` Ralf Baechle
2007-09-17 23:04             ` Steve Graham
2007-09-18  8:52               ` Ralf Baechle
2007-09-17 23:20             ` David Daney
2007-09-18  8:47               ` Ralf Baechle
2007-07-02 14:34 ` Maciej W. Rozycki
2007-09-21  6:27 ` Sagar Borikar
2007-09-21 13:47   ` Ralf Baechle
2007-09-22  3:20     ` Steve Graham
2007-09-24 11:58       ` Ralf Baechle
2007-09-26 17:06         ` Steve Graham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469C75BC.5040501@niisi.msk.ru \
    --to=raiko@niisi.msk.ru \
    --cc=kumba@gentoo.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=rogozhkin@niisi.msk.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.