From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@qumranet.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
KVM devel <kvm-devel@lists.sourceforge.net>,
Jeff Dike <jdike@addtoit.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [kvm-devel] [PATCH 2/3] KVM - Fix hypercall arguments
Date: Tue, 17 Jul 2007 08:42:22 -0500 [thread overview]
Message-ID: <469CC73E.8000306@codemonkey.ws> (raw)
In-Reply-To: <469C7A9E.30207@qumranet.com>
Avi Kivity wrote:
> Jeff Dike wrote:
>
>> It looks like kvm_hypercall is trying to match the system call
>> convention and mixed up the call number and first argument in the
>> 32-bit case.
>>
>> Signed-off-by: Jeff Dike <jdike@linux.intel.com>
>> --
>> drivers/kvm/kvm_main.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Index: kvm/drivers/kvm/kvm_main.c
>> ===================================================================
>> --- kvm.orig/drivers/kvm/kvm_main.c
>> +++ kvm/drivers/kvm/kvm_main.c
>> @@ -1351,8 +1351,8 @@ int kvm_hypercall(struct kvm_vcpu *vcpu,
>> } else
>> #endif
>> {
>> - nr = vcpu->regs[VCPU_REGS_RBX] & -1u;
>> - a0 = vcpu->regs[VCPU_REGS_RAX] & -1u;
>> + nr = vcpu->regs[VCPU_REGS_RAX] & -1u;
>> + a0 = vcpu->regs[VCPU_REGS_RBX] & -1u;
>> a1 = vcpu->regs[VCPU_REGS_RCX] & -1u;
>> a2 = vcpu->regs[VCPU_REGS_RDX] & -1u;
>> a3 = vcpu->regs[VCPU_REGS_RSI] & -1u;
>>
>>
>
> Anthony? I think you were hacking this area?
>
I make a similar change in my series.
Regards,
Anthony Liguori
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: KVM devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Jeff Dike <jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/3] KVM - Fix hypercall arguments
Date: Tue, 17 Jul 2007 08:42:22 -0500 [thread overview]
Message-ID: <469CC73E.8000306@codemonkey.ws> (raw)
In-Reply-To: <469C7A9E.30207-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Avi Kivity wrote:
> Jeff Dike wrote:
>
>> It looks like kvm_hypercall is trying to match the system call
>> convention and mixed up the call number and first argument in the
>> 32-bit case.
>>
>> Signed-off-by: Jeff Dike <jdike-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>> --
>> drivers/kvm/kvm_main.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Index: kvm/drivers/kvm/kvm_main.c
>> ===================================================================
>> --- kvm.orig/drivers/kvm/kvm_main.c
>> +++ kvm/drivers/kvm/kvm_main.c
>> @@ -1351,8 +1351,8 @@ int kvm_hypercall(struct kvm_vcpu *vcpu,
>> } else
>> #endif
>> {
>> - nr = vcpu->regs[VCPU_REGS_RBX] & -1u;
>> - a0 = vcpu->regs[VCPU_REGS_RAX] & -1u;
>> + nr = vcpu->regs[VCPU_REGS_RAX] & -1u;
>> + a0 = vcpu->regs[VCPU_REGS_RBX] & -1u;
>> a1 = vcpu->regs[VCPU_REGS_RCX] & -1u;
>> a2 = vcpu->regs[VCPU_REGS_RDX] & -1u;
>> a3 = vcpu->regs[VCPU_REGS_RSI] & -1u;
>>
>>
>
> Anthony? I think you were hacking this area?
>
I make a similar change in my series.
Regards,
Anthony Liguori
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-17 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 19:24 [PATCH 2/3] KVM - Fix hypercall arguments Jeff Dike
2007-07-16 19:24 ` Jeff Dike
2007-07-17 8:15 ` Avi Kivity
2007-07-17 8:15 ` Avi Kivity
2007-07-17 13:42 ` Anthony Liguori [this message]
2007-07-17 13:42 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469CC73E.8000306@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=jdike@addtoit.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.