All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	stable@kernel.org, Greg KH <greg@kroah.com>,
	Chris Wright <chrisw@sous-sol.org>
Subject: Re: [patch] fix the softlockup watchdog to actually work
Date: Thu, 19 Jul 2007 08:04:26 -0700	[thread overview]
Message-ID: <469F7D7A.204@goop.org> (raw)
In-Reply-To: <20070719145058.GA11971@elte.hu>

Ingo Molnar wrote:
> no, the return value after idling can be completely random on some 
> boxes, on a 64-bit scale - triggering the softlockup watchdog randomly. 
> (some boxes return random TSC values, etc.) Again, it's fine for the 
> scheduler's purpose, that's why i named it sched_clock().
>
> the proper clocksource use within the kernel is ktime_get() [or 
> ktime_get_ts()]. Do not abuse sched_clock() for such things.

Well, my observation is that both softlockup and the scheduler really
want to measure unstolen time, so it seemed to me that sched_clock was a
nice common place to implement that, rather than implementing a whole
new time interface.  At the time that seemed OK, and nobody had any
objections.

But it's a bit beside the point unless it does turn out to be making
Andrew's Vaio sad.

    J

  reply	other threads:[~2007-07-19 15:05 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-17 11:44 [patch] softlockup watchdog: fix Xen bogosity Ingo Molnar
2007-07-17 14:17 ` Jeremy Fitzhardinge
2007-07-17 15:49   ` [patch] fix the softlockup watchdog to actually work Ingo Molnar
2007-07-17 17:03     ` Randy Dunlap
2007-07-17 17:25       ` Ingo Molnar
2007-07-17 18:14       ` Linus Torvalds
2007-07-17 21:38         ` Randy Dunlap
2007-07-19  7:22     ` Andrew Morton
2007-07-19  7:46       ` Ingo Molnar
2007-07-19  7:51       ` Ingo Molnar
2007-07-19 14:31         ` Jeremy Fitzhardinge
2007-07-19 14:35           ` Ingo Molnar
2007-07-19 14:40             ` Jeremy Fitzhardinge
2007-07-19 14:46             ` Jeremy Fitzhardinge
2007-07-19 14:50               ` Ingo Molnar
2007-07-19 15:04                 ` Jeremy Fitzhardinge [this message]
2007-07-19 15:09                   ` Ingo Molnar
2007-07-19 15:21                     ` Jeremy Fitzhardinge
2007-07-19 15:42                       ` [patch] sched: implement cpu_clock(cpu) high-speed time source Ingo Molnar
2007-07-19 15:44                         ` [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2 Ingo Molnar
2007-07-19 16:11                           ` Jeremy Fitzhardinge
2007-07-19 16:16                             ` Ingo Molnar
2007-07-19 16:18                               ` Jeremy Fitzhardinge
2007-07-19 16:21                                 ` Ingo Molnar
2007-07-19 16:29                                   ` Jeremy Fitzhardinge
2007-07-19 17:24                             ` Jens Axboe
2007-07-19 18:10                               ` Jeremy Fitzhardinge
2007-07-19 18:20                                 ` Jens Axboe
2007-07-25  8:49     ` [patch] fix the softlockup watchdog to actually work Andrew Morton
2007-07-25  8:52       ` Ingo Molnar
2007-07-25  8:55         ` Ingo Molnar
2007-07-25  9:00         ` Andrew Morton
2007-07-25  9:04           ` Ingo Molnar
2007-07-25  9:17             ` Andrew Morton
2007-07-25  9:23               ` Ingo Molnar
2007-07-25  9:59                 ` Jens Axboe
2007-07-25 11:04                   ` Ingo Molnar
2007-07-25 11:06                     ` Jens Axboe
2007-07-25 16:34       ` Andi Kleen
2007-10-03 23:49     ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469F7D7A.204@goop.org \
    --to=jeremy@goop.org \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.