From: Rene Herman <rene.herman@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Paul Mackerras <paulus@samba.org>, Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <James.Bottomley@SteelEye.com>,
Linux/PPC Development <linuxppc-dev@ozlabs.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org,
Geoff Levand <geoffrey.levand@am.sony.com>
Subject: Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver
Date: Thu, 19 Jul 2007 19:56:53 +0200 [thread overview]
Message-ID: <469FA5E5.3070301@gmail.com> (raw)
In-Reply-To: <20070719024730.03609f1f.akpm@linux-foundation.org>
On 07/19/2007 11:47 AM, Andrew Morton wrote:
> On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
>
>>> Oh dear.
>>>
>>> ps3rom_priv(dev) = host;
>>>
>>> that's 'orrid. We have an identifier pretending to be a function, only we
>>> go and treat it as an lvalue.
>>>
>>> I mean, C code should look like C code, and the above just doesn't.
>>>
>>> Sigh.
You could insist that it be PS3ROM_PRIV() because then it at least also
_looks_ like cpp...
Rene.
WARNING: multiple messages have this Message-ID (diff)
From: Rene Herman <rene.herman@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/PPC Development <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver
Date: Thu, 19 Jul 2007 19:56:53 +0200 [thread overview]
Message-ID: <469FA5E5.3070301@gmail.com> (raw)
In-Reply-To: <20070719024730.03609f1f.akpm@linux-foundation.org>
On 07/19/2007 11:47 AM, Andrew Morton wrote:
> On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
>
>>> Oh dear.
>>>
>>> ps3rom_priv(dev) = host;
>>>
>>> that's 'orrid. We have an identifier pretending to be a function, only we
>>> go and treat it as an lvalue.
>>>
>>> I mean, C code should look like C code, and the above just doesn't.
>>>
>>> Sigh.
You could insist that it be PS3ROM_PRIV() because then it at least also
_looks_ like cpp...
Rene.
next prev parent reply other threads:[~2007-07-19 17:56 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 16:15 [patch 0/3] PS3 Storage Drivers for 2.6.23, take 5 Geert Uytterhoeven
2007-07-16 16:15 ` Geert Uytterhoeven
2007-07-16 16:15 ` Geert Uytterhoeven
2007-07-16 16:15 ` [patch 1/3] ps3: Disk Storage Driver Geert Uytterhoeven
2007-07-16 16:15 ` Geert Uytterhoeven
2007-07-16 16:15 ` Geert Uytterhoeven
2007-07-18 14:32 ` Jan Engelhardt
2007-07-18 14:32 ` Jan Engelhardt
2007-07-18 14:32 ` Jan Engelhardt
2007-07-18 15:36 ` Geert Uytterhoeven
2007-07-18 15:36 ` Geert Uytterhoeven
2007-07-18 23:36 ` Andrew Morton
2007-07-18 23:36 ` Andrew Morton
2007-07-19 5:33 ` Jens Axboe
2007-07-19 5:33 ` Jens Axboe
2007-07-19 7:15 ` Geert Uytterhoeven
2007-07-19 7:15 ` Geert Uytterhoeven
2007-07-19 7:15 ` Geert Uytterhoeven
2007-07-19 8:57 ` Geert Uytterhoeven
2007-07-19 8:57 ` Geert Uytterhoeven
2007-07-19 8:57 ` Geert Uytterhoeven
2007-07-19 9:10 ` Andrew Morton
2007-07-19 9:10 ` Andrew Morton
2007-07-19 13:52 ` [patch 0/4] PS3 storage driver updates (was: Re: [patch 1/3] ps3: Disk Storage Driver) Geert Uytterhoeven
2007-07-19 13:52 ` Geert Uytterhoeven
2007-07-19 13:53 ` [patch 1/4] ps3disk: use correct bio vector size Geert Uytterhoeven
2007-07-19 13:53 ` Geert Uytterhoeven
2007-07-19 13:54 ` [patch 2/4] ps3disk: updates after final review Geert Uytterhoeven
2007-07-19 13:54 ` Geert Uytterhoeven
2007-07-19 13:54 ` [patch 3/4] ps3rom: " Geert Uytterhoeven
2007-07-19 13:54 ` Geert Uytterhoeven
2007-07-19 13:55 ` [patch 4/4] ps3flash: " Geert Uytterhoeven
2007-07-19 13:55 ` Geert Uytterhoeven
2007-07-19 9:26 ` [patch 1/3] ps3: Disk Storage Driver Cornelia Huck
2007-07-19 9:26 ` Cornelia Huck
2007-07-19 9:36 ` Geert Uytterhoeven
2007-07-19 9:36 ` Geert Uytterhoeven
2007-07-19 12:00 ` Cornelia Huck
2007-07-19 12:00 ` Cornelia Huck
2007-07-19 12:13 ` Geert Uytterhoeven
2007-07-19 12:13 ` Geert Uytterhoeven
2007-07-19 12:52 ` Cornelia Huck
2007-07-19 12:52 ` Cornelia Huck
2007-07-24 11:44 ` Andy Whitcroft
2007-07-24 11:44 ` Andy Whitcroft
2007-07-24 12:37 ` Jeff Garzik
2007-07-24 12:37 ` Jeff Garzik
2007-07-24 12:52 ` Andreas Schwab
2007-07-24 12:52 ` Andreas Schwab
2007-07-24 12:52 ` Andreas Schwab
2007-07-24 13:44 ` Jeff Garzik
2007-07-24 13:44 ` Jeff Garzik
2007-07-24 16:43 ` Andrew Morton
2007-07-24 16:43 ` Andrew Morton
2007-07-24 16:43 ` Andrew Morton
2007-07-25 1:09 ` Paul Mackerras
2007-07-25 1:09 ` Paul Mackerras
2007-07-25 1:21 ` Andrew Morton
2007-07-25 1:21 ` Andrew Morton
2007-07-16 16:15 ` [patch 2/3] ps3: BD/DVD/CD-ROM " Geert Uytterhoeven
2007-07-16 16:15 ` Geert Uytterhoeven
2007-07-16 16:15 ` Geert Uytterhoeven
2007-07-18 23:43 ` Andrew Morton
2007-07-18 23:43 ` Andrew Morton
2007-07-19 9:02 ` Geert Uytterhoeven
2007-07-19 9:02 ` Geert Uytterhoeven
2007-07-19 9:02 ` Geert Uytterhoeven
2007-07-19 9:17 ` Andrew Morton
2007-07-19 9:17 ` Andrew Morton
2007-07-19 9:39 ` Geert Uytterhoeven
2007-07-19 9:39 ` Geert Uytterhoeven
2007-07-19 9:41 ` Jens Axboe
2007-07-19 9:41 ` Jens Axboe
2007-07-19 9:47 ` Andrew Morton
2007-07-19 9:47 ` Andrew Morton
2007-07-19 9:47 ` Andrew Morton
2007-07-19 17:56 ` Rene Herman [this message]
2007-07-19 17:56 ` Rene Herman
2007-07-16 16:15 ` [patch 3/3] ps3: FLASH ROM " Geert Uytterhoeven
2007-07-16 16:15 ` Geert Uytterhoeven
2007-07-16 16:15 ` Geert Uytterhoeven
2007-07-18 23:52 ` Andrew Morton
2007-07-18 23:52 ` Andrew Morton
2007-07-19 11:25 ` Geert Uytterhoeven
2007-07-19 11:25 ` Geert Uytterhoeven
2007-07-19 6:40 ` [patch 0/3] PS3 Storage Drivers for 2.6.23, take 5 Alessandro Rubini
2007-07-19 6:40 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469FA5E5.3070301@gmail.com \
--to=rene.herman@gmail.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.