Re: [SUBPATCH IPTABLES 0/43]: Unification of ip[6]tables matches/targets #3

Re: [SUBPATCH IPTABLES 0/43]: Unification of ip[6]tables matches/targets #3

[Patrick McHardy]

Yasuyuki KOZAKAI wrote:
> I've updated libxt_tcp and libxt_multiport according to comments from Jan.
> This time I post only updated patches and the undeliverd patch in previous
> time due to large patch.
>
> [09-1/43] Fixed warning on compilation of iptables matches/targets
> [09-2/43] Fixed warning on compilation of ip6tables matches/targets
> [10/43] fixed warning on compilation, part 2
> [17/43] Use unified API in multiport match.
> [18/43] Split ipt_multport into family dependent parts and others
> [19/43] Moves libipt_multiport.c to libxt_multiport.c
> [20/43] Unifies libip[6]t_multiport.c into libipxt_multiport.c
> [28/43] Unifies libip[6]t_tcp.c into libxt_tcp.c
>   

Looks good to me.

> From: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
>
>   
>> Well, I found missing FIN in text of help() in libipt_tcp.c then also
>> fixed. New release is necessary again ? grrr..  If so, I'll change version
>> in Makefile, and apply xtables patches to main trunk.
>>     
>
> If no one wants new release again before commiting thse patches,
> I'll commit them into main trunk without changing version in Makefile
> next week (maybe Tuesday).


Great, thanks a lot Yasuyuki. I'm really looking forward to seeing
this in SVN.

Re: [PATCH 28/43] Unifies libip[6]t_tcp.c into libxt_tcp.c.

[Yasuyuki KOZAKAI]

From: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>

> > > Since SYN+FIN does not make much sense (unless the ipv6-tcp protocol _really_
> > > allowed that), libipt_tcp's definition should be used.
> > 
> > 
> > Agreed, that should work fine for both.
> 
> OK, I don't come up with bad impact to current user, too.
> I'll fix that before applying xtables pathes.

Well, I found missing FIN in text of help() in libipt_tcp.c then also
fixed. New release is necessary again ? grrr..  If so, I'll change version
in Makefile, and apply xtables patches to main trunk.


-- Yasuyuki Kozakai

[SUBPATCH IPTABLES 0/43]: Unification of ip[6]tables matches/targets #3

[Yasuyuki KOZAKAI]

I've updated libxt_tcp and libxt_multiport according to comments from Jan.
This time I post only updated patches and the undeliverd patch in previous
time due to large patch.

[09-1/43] Fixed warning on compilation of iptables matches/targets
[09-2/43] Fixed warning on compilation of ip6tables matches/targets
[10/43] fixed warning on compilation, part 2
[17/43] Use unified API in multiport match.
[18/43] Split ipt_multport into family dependent parts and others
[19/43] Moves libipt_multiport.c to libxt_multiport.c
[20/43] Unifies libip[6]t_multiport.c into libipxt_multiport.c
[28/43] Unifies libip[6]t_tcp.c into libxt_tcp.c

From: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>

> Well, I found missing FIN in text of help() in libipt_tcp.c then also
> fixed. New release is necessary again ? grrr..  If so, I'll change version
> in Makefile, and apply xtables patches to main trunk.

If no one wants new release again before commiting thse patches,
I'll commit them into main trunk without changing version in Makefile
next week (maybe Tuesday).

-- Yasuyuki Kozakai