From: Chris Snook <csnook@redhat.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: info@netxen.com, Luke Yang <luke.yang@analog.com>,
Judy Fischbach <jfisch@cs.pdx.edu>,
Patrick McHardy <kaber@coreworks.de>,
bonding-devel@lists.sourceforge.net,
Bryan Wu <bryan.wu@analog.com>,
kong.lai@tundra.com, Jay Vosburgh <fubar@us.ibm.com>,
James Morris <jmorris@namei.org>,
linuxppc-embedded@ozlabs.org,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Alex V Lasso <a_villacis@palosanto.com>,
Ulrich Kunitz <kune@deine-taler.de>,
Chad Tindel <ctindel@users.sourceforge.net>,
Amit S Kale <amitkale@netxen.com>,
Jay Cliburn <jcliburn@gmail.com>,
Samuel Ortiz <samuel@sortiz.org>, Daniel Drake <dsd@gentoo.org>,
Brian Pugh <bpugh@cs.pdx.edu>,
viro@ftp.linux.org.uk, alexandre.bounine@tundra.com,
Pantelis Antoniou <panto@intracom.gr>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Vitaly Bordug <vbordug@ru.mvista.com>,
Lukasz Stelmach <stlman@poczta.fm>,
Ron Mercer <linux-driver@qlogic.com>,
atl1-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
James P Ketrenos <ipw2100-admin@linux.intel.com>
Subject: Re: [PATCH][12/37] Clean up duplicate includes in drivers/net/
Date: Sat, 21 Jul 2007 12:50:26 -0400 [thread overview]
Message-ID: <46A23952.6060207@redhat.com> (raw)
In-Reply-To: <9a8748490707210948k468f8f32k718d84279aa56ce9@mail.gmail.com>
Jesper Juhl wrote:
> On 21/07/07, Chris Snook <csnook@redhat.com> wrote:
>> Jesper Juhl wrote:
>> > Hi,
>> >
>> > This patch cleans up duplicate includes in
>> > drivers/net/
>> >
>> >
>> > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
>> > ---
>> >
>> > diff --git a/drivers/net/atl1/atl1_main.c
>> b/drivers/net/atl1/atl1_main.c
>> > index fd1e156..4a18b88 100644
>> > --- a/drivers/net/atl1/atl1_main.c
>> > +++ b/drivers/net/atl1/atl1_main.c
>> > @@ -75,7 +75,6 @@
>> > #include <linux/compiler.h>
>> > #include <linux/delay.h>
>> > #include <linux/mii.h>
>> > -#include <linux/interrupt.h>
>> > #include <net/checksum.h>
>> >
>> > #include <asm/atomic.h>
>>
>> Define "duplicate". I ask because this patch just got posted a few
>> days ago:
>>
>
> duplicate == present more than once in the same source file.
> Did you try looking at the includes in the source file the patch modifies?
Nope! Mea Culpa.
-- Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Snook <csnook@redhat.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: info@netxen.com, Luke Yang <luke.yang@analog.com>,
Judy Fischbach <jfisch@cs.pdx.edu>,
Patrick McHardy <kaber@coreworks.de>,
bonding-devel@lists.sourceforge.net,
Bryan Wu <bryan.wu@analog.com>,
kong.lai@tundra.com, Jay Vosburgh <fubar@us.ibm.com>,
James Morris <jmorris@namei.org>,
linuxppc-embedded@ozlabs.org,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Alex V Lasso <a_villacis@palosanto.com>,
Ulrich Kunitz <kune@deine-taler.de>,
Chad Tindel <ctindel@users.sourceforge.net>,
Amit S Kale <amitkale@netxen.com>,
Jay Cliburn <jcliburn@gmail.com>,
Samuel Ortiz <samuel@sortiz.org>, Daniel Drake <dsd@gentoo.org>,
Brian Pugh <bpugh@cs.pdx.edu>,
viro@ftp.linux.org.uk, alexandre.bounine@tundra.com,
Pantelis Antoniou <panto@intracom.gr>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.or
Subject: Re: [PATCH][12/37] Clean up duplicate includes in drivers/net/
Date: Sat, 21 Jul 2007 12:50:26 -0400 [thread overview]
Message-ID: <46A23952.6060207@redhat.com> (raw)
In-Reply-To: <9a8748490707210948k468f8f32k718d84279aa56ce9@mail.gmail.com>
Jesper Juhl wrote:
> On 21/07/07, Chris Snook <csnook@redhat.com> wrote:
>> Jesper Juhl wrote:
>> > Hi,
>> >
>> > This patch cleans up duplicate includes in
>> > drivers/net/
>> >
>> >
>> > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
>> > ---
>> >
>> > diff --git a/drivers/net/atl1/atl1_main.c
>> b/drivers/net/atl1/atl1_main.c
>> > index fd1e156..4a18b88 100644
>> > --- a/drivers/net/atl1/atl1_main.c
>> > +++ b/drivers/net/atl1/atl1_main.c
>> > @@ -75,7 +75,6 @@
>> > #include <linux/compiler.h>
>> > #include <linux/delay.h>
>> > #include <linux/mii.h>
>> > -#include <linux/interrupt.h>
>> > #include <net/checksum.h>
>> >
>> > #include <asm/atomic.h>
>>
>> Define "duplicate". I ask because this patch just got posted a few
>> days ago:
>>
>
> duplicate == present more than once in the same source file.
> Did you try looking at the includes in the source file the patch modifies?
Nope! Mea Culpa.
-- Chris
next prev parent reply other threads:[~2007-07-21 16:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 15:02 [PATCH][12/37] Clean up duplicate includes in drivers/net/ Jesper Juhl
2007-07-21 15:02 ` Jesper Juhl
2007-07-21 16:40 ` Chris Snook
2007-07-21 16:40 ` Chris Snook
2007-07-21 16:46 ` Al Viro
2007-07-21 16:46 ` Al Viro
2007-07-21 16:48 ` Jesper Juhl
2007-07-21 16:48 ` Jesper Juhl
2007-07-21 16:50 ` Chris Snook [this message]
2007-07-21 16:50 ` Chris Snook
2007-07-23 13:22 ` John W. Linville
2007-07-23 13:22 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A23952.6060207@redhat.com \
--to=csnook@redhat.com \
--cc=a_villacis@palosanto.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.bounine@tundra.com \
--cc=amitkale@netxen.com \
--cc=atl1-devel@lists.sourceforge.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=bpugh@cs.pdx.edu \
--cc=bryan.wu@analog.com \
--cc=ctindel@users.sourceforge.net \
--cc=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=fubar@us.ibm.com \
--cc=info@netxen.com \
--cc=ipw2100-admin@linux.intel.com \
--cc=jcliburn@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=jfisch@cs.pdx.edu \
--cc=jmorris@namei.org \
--cc=kaber@coreworks.de \
--cc=kong.lai@tundra.com \
--cc=kune@deine-taler.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=luke.yang@analog.com \
--cc=netdev@vger.kernel.org \
--cc=panto@intracom.gr \
--cc=ralf@linux-mips.org \
--cc=samuel@sortiz.org \
--cc=stlman@poczta.fm \
--cc=vbordug@ru.mvista.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.