All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henning Sprang <henning_sprang@gmx.de>
To: Henning Sprang <henning_sprang@gmx.de>
Cc: Xen <xen-devel@lists.xensource.com>, Keir Fraser <keir@xensource.com>
Subject: Re: Xendomain Bug
Date: Sun, 22 Jul 2007 13:33:13 +0200	[thread overview]
Message-ID: <46A34079.3010507@gmx.de> (raw)
In-Reply-To: <46922744.60403@gmx.de>

Henning Sprang wrote:
> Keir Fraser wrote:
>> Changeset 15384 in xen-unstable (committed on June 19th) should fix this
>> issue.

Hmm, there is still one question left:

The fix I proposed is a patch of about two lines - as can be seen here:
http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=859

The fix you took in was much larger instead - in fact 2 lines vs. 20.

see: http://xenbits.xensource.com/xen-unstable.hg?rev/865c4ae59be3

Is there something totally wrong with the small patch that I oversaw?

Not that I have the urgent need to get my own patches in, but I usually
tend to think smaller patches should be better, and having less code to
maintain is better - and if I propose bad things, I want to know about it :)

Henning

  reply	other threads:[~2007-07-22 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-09  7:58 Xendomain Bug Henning Sprang
2007-07-09  8:36 ` Keir Fraser
2007-07-09 12:17   ` Henning Sprang
2007-07-22 11:33     ` Henning Sprang [this message]
2007-07-22 12:01       ` Keir Fraser
2007-07-23 19:09         ` Henning Sprang
2007-07-24  6:25           ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A34079.3010507@gmx.de \
    --to=henning_sprang@gmx.de \
    --cc=keir@xensource.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.