[lm-sensors] PATCH: hwmon-fscher-bugfix-control-update.patch

[lm-sensors] PATCH: hwmon-fscher-bugfix-control-update.patch

[Hans de Goede]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

Mark,

Here is another small fscher bugfix for 2.6.23 merging, this was caught by Jean
while reviewing my other bugfix. The driver was updating its copy of the
control register as if it was clear to write, but its regular read/write.
This patch fixes this.

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Regards,

Hans

[-- Attachment #2: hwmon-fscher-bugfix-control-update.patch --]
[-- Type: text/x-patch, Size: 876 bytes --]

Mark,

Here is another small fscher bugfix for 2.6.23 merging, this was caught by Jean
while reviewing my other bugfix. The driver was updating its copy of the
control register as if it was clear to write, but its regular read/write.
This patch fixes this.

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
diff -up linux-2.6.22.x86_64/drivers/hwmon/fscher.c~ linux-2.6.22.x86_64/drivers/hwmon/fscher.c
--- linux-2.6.22.x86_64/drivers/hwmon/fscher.c~	2007-07-22 20:11:06.000000000 +0200
+++ linux-2.6.22.x86_64/drivers/hwmon/fscher.c	2007-07-22 20:11:06.000000000 +0200
@@ -599,7 +599,7 @@ static ssize_t set_control(struct i2c_cl
 	unsigned long v = simple_strtoul(buf, NULL, 10) & 0x01;
 
 	mutex_lock(&data->update_lock);
-	data->global_control &= ~v;
+	data->global_control = v;
 	fscher_write_value(client, reg, v);
 	mutex_unlock(&data->update_lock);
 	return count;

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: hwmon-fscher-bugfix-control-update.patch

[Jean Delvare]

On Sun, 22 Jul 2007 20:15:31 +0200, Hans de Goede wrote:
> Here is another small fscher bugfix for 2.6.23 merging, this was caught by Jean
> while reviewing my other bugfix. The driver was updating its copy of the
> control register as if it was clear to write, but its regular read/write.
> This patch fixes this.
> 
> Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Acked-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: hwmon-fscher-bugfix-control-update.patch

[Mark M. Hoffman]

Hi Hans, Jean:

* Jean Delvare <khali@linux-fr.org> [2007-07-23 22:19:28 +0200]:
> On Sun, 22 Jul 2007 20:15:31 +0200, Hans de Goede wrote:
> > Here is another small fscher bugfix for 2.6.23 merging, this was caught by Jean
> > while reviewing my other bugfix. The driver was updating its copy of the
> > control register as if it was clear to write, but its regular read/write.
> > This patch fixes this.
> > 
> > Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors