Re: VM id in KVM?

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Rusty Russell wrote:
> On Mon, 2007-07-23 at 14:32 +0100, Daniel P. Berrange wrote:
>   
>> As Avi 
>> says I dont't see how a individual QEMU process could provide any meaningful
>> identifier itself aside from its PID whose uniqueness is guarenteed by the
>> OS on its behalf.
>>     
>
> Indeed.  I use it in my pr_guest() patch which replaces all those
> printks with:
>
> +/* The guest did something wrong/strange. */
> +#define pr_guest(vcpu, fmt, ...)					\
> +	do {								\
> +		if (__printk_ratelimit(5*HZ, 10))			\
> +			printk(KERN_WARNING "kvm: %i: cpu%i " fmt,	\
> +			       (vcpu)->kvm->pid, (vcpu)->vcpu_id	\
> +			       , ## __VA_ARGS__);			\
> +	} while(0)
>
> I'll polish it up and send it on.  I don't want Avi getting bored.
>
>   

With the ioctl interface, vms aren't really tied to tasks.

How about current->pid (or with struct pid and containers, probably
current->something->something->pid)?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/