mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

florian commit schreef:

> +PACKAGE_ARCH = "${MACHINE}"

This has to stop, OE is usable without setting MACHINE. The correct form is either

PACKAGE_ARCH = "${MACHINE_ARCH}"

or by setting SRC_URI_OVERRIDES_PACKAGE_ARCH (see base.bbclass) appropriately

regards,

Koen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFGpggyMkyGM64RGpERAvw+AKCY9ytYPx1zFTw7aljuDG3cc50RLgCeLaEU
tWzfaAUTRB99Ls3CNcDAcbY=
=Vx2C
-----END PGP SIGNATURE-----

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Florian Boor]

Hi,


Koen Kooi schrieb:
> florian commit schreef:
> 
>> +PACKAGE_ARCH = "${MACHINE}"
> 
> This has to stop, OE is usable without setting MACHINE. The correct form is either
> 
> PACKAGE_ARCH = "${MACHINE_ARCH}"

thanks for the hint.

For these trivial changes that do not break much I would really like to see if
people do not disapprove    the whole patch but just go ahead and fix the
problem - that is way more productive.

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de

1D78 2D4D 6C53 1CA4 5588  D07B A8E7 940C 25B7 9A76

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Florian Boor schreef:
> Hi,
> 
> 
> Koen Kooi schrieb:
>> florian commit schreef:
>>
>>> +PACKAGE_ARCH = "${MACHINE}"
>> This has to stop, OE is usable without setting MACHINE. The correct form is either
>>
>> PACKAGE_ARCH = "${MACHINE_ARCH}"
> 
> thanks for the hint.
> 
> For these trivial changes that do not break much I would really like to see if
> people do not disapprove    the whole patch but just go ahead and fix the
> problem - that is way more productive.

You are right that it's more productive to fix small errors than to disapprove, but:
I did that the first few times with PACKAGE_ARCH = "${MACHINE}", and people still keep
adding it, so now I'm doing dissaprove + mail to oe-devel to raise awareness.
Fixing errors afterwards is only productive if people learn from it and stop making the
same error again, which wasn't the case here.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFGpyYvMkyGM64RGpERAgw7AJ9tKipgz+vizFvVePbq1/HBWJs+LwCgsu6R
DN165yNkXzUHhUvuzoCmJEE=
=dO8M
-----END PGP SIGNATURE-----

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Florian Boor]

Hi,

Koen Kooi schrieb:
> You are right that it's more productive to fix small errors than to disapprove, but:
> I did that the first few times with PACKAGE_ARCH = "${MACHINE}", and people still keep
> adding it, so now I'm doing dissaprove + mail to oe-devel to raise awareness.
> Fixing errors afterwards is only productive if people learn from it and stop making the
> same error again, which wasn't the case here.

didn't I react on the mail to the list?
Did I introduce a similar bug lately?

I really do not appreciate if people revert a complete change for the lack of
five bytes. That wastes too much of precious time - I can live with that, but I
do not want such reactions causing other contributors to run away.

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de

1D78 2D4D 6C53 1CA4 5588  D07B A8E7 940C 25B7 9A76

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Philippe De Swert]

Hi,

On Wed, 2007-07-25 at 13:04 +0200, Florian Boor wrote:
> Hi,
> 
> Koen Kooi schrieb:
> > You are right that it's more productive to fix small errors than to disapprove, but:
> > I did that the first few times with PACKAGE_ARCH = "${MACHINE}", and people still keep
> > adding it, so now I'm doing dissaprove + mail to oe-devel to raise awareness.
> > Fixing errors afterwards is only productive if people learn from it and stop making the
> > same error again, which wasn't the case here.
> 
> didn't I react on the mail to the list?
> Did I introduce a similar bug lately?
> 
> I really do not appreciate if people revert a complete change for the lack of
> five bytes. That wastes too much of precious time - I can live with that, but I
> do not want such reactions causing other contributors to run away.

I tend to agree with Florian here. However the first time you need to
fix it mail the person who made the mistake and cc the mailing list so
everybody knows. Only afterwards you can start disapproving commits.

Cheers,

Philippe

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Richard Purdie]

Hi,

On Wed, 2007-07-25 at 16:12 +0300, Philippe De Swert wrote:
> On Wed, 2007-07-25 at 13:04 +0200, Florian Boor wrote:
> > Koen Kooi schrieb:
> > > You are right that it's more productive to fix small errors than to disapprove, but:
> > > I did that the first few times with PACKAGE_ARCH = "${MACHINE}", and people still keep
> > > adding it, so now I'm doing dissaprove + mail to oe-devel to raise awareness.
> > > Fixing errors afterwards is only productive if people learn from it and stop making the
> > > same error again, which wasn't the case here.
> > 
> > didn't I react on the mail to the list?
> > Did I introduce a similar bug lately?
> > 
> > I really do not appreciate if people revert a complete change for the lack of
> > five bytes. That wastes too much of precious time - I can live with that, but I
> > do not want such reactions causing other contributors to run away.
> 
> I tend to agree with Florian here. However the first time you need to
> fix it mail the person who made the mistake and cc the mailing list so
> everybody knows. Only afterwards you can start disapproving commits.

We've been chasing people introducing that particular bug for a while,
there are commits from me 18 months ago fixing it and I'm fairly sure
florian has been told about it before.

A disapprove could therefore arguably be justified to raise the profile
of the problem a bit since if its been going on for 18 months, the
message has not sunk in. Thats been done, the profile has been raised,
lets get back to normal now :).

Cheers,

Richard

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Michael Krelin]

> A disapprove could therefore arguably be justified to raise the profile
> of the problem a bit since if its been going on for 18 months, the
> message has not sunk in. Thats been done, the profile has been raised,
> lets get back to normal now :).

What about emailing the list with the [oe] mtn disapprove subject and 
raising a problem without actually disapproving? :) It would both look 
like a disciplinary decision (if someone wants to look that way) and 
save a lot of hassle to Florian ;-)

Love,
H

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Krelin schreef:

> What about emailing the list with the [oe] mtn disapprove subject and 
> raising a problem without actually disapproving? 

Good idea, with one flaw: You assume every developer is subscribed to this mailinglist,
which sadly isn't the case.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFGp3HkMkyGM64RGpERAlC7AJ4xbHOrgJ+FUMcVJlIS0ReaGatEUQCdEK89
1uIqq4usfCKATxMP3Eooj10=
=CEC6
-----END PGP SIGNATURE-----

Why many small commits are better than one big one.

[jack-oe]

On Wed, Jul 25, 2007 at 12:30:07PM +0200, Koen Kooi wrote:
 
> You are right that it's more productive to fix small errors than to disapprove, but:
> I did that the first few times with PACKAGE_ARCH = "${MACHINE}", and people still keep
> adding it, so now I'm doing dissaprove + mail to oe-devel to raise awareness.
> Fixing errors afterwards is only productive if people learn from it and stop making the
> same error again, which wasn't the case here.

"disapprove" is a useful command. 

If you commit your changes in multiple orthogonal commits, it is possible to
disapprove only the controversial parts. Prevents throwing the baby out with
the bathwater.

Cheers, 

--Jack 

--
Jack (John) Cummings                           http://mudshark.org/
PGP fingerprint: F18B 13A3 6D06 D48A 598D  42EA 3D53 BDC8 7917 F802

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Michael Krelin]

>> What about emailing the list with the [oe] mtn disapprove subject and 
>> raising a problem without actually disapproving? 
> 
> Good idea, with one flaw: You assume every developer is subscribed to this mailinglist,
> which sadly isn't the case.

That is a problem in itself, I'd say...

Love,
H

Re: Why many small commits are better than one big one.

[Florian Boor]

Hi,

jack-oe@mudshark.org schrieb:

> If you commit your changes in multiple orthogonal commits, it is possible to
> disapprove only the controversial parts. Prevents throwing the baby out with
> the bathwater.

I guess you should take a look at the change you are talking about. Otherwise
this could become a shame for you ;)

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-14
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de

1D78 2D4D 6C53 1CA4 5588  D07B A8E7 940C 25B7 9A76

Re: mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Koen Kooi schreef:
> florian commit schreef:
> 
>> +PACKAGE_ARCH = "${MACHINE}"
> 
> This has to stop, OE is usable without setting MACHINE. The correct form is either
> 
> PACKAGE_ARCH = "${MACHINE_ARCH}"

+++ packages/openmoko2/neod_svn.bb	5425e0836b76f5378b1da4b9f6540f1595380b8d

+PACKAGE_ARCH = "${MACHINE}"

*sigh*


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFG55G5MkyGM64RGpERAiSmAJsHvKA7bJAkqv6Uq13WlJKflGScZgCeOjuh
dvChFj0tgwy0g4hQ8v8LpHc=
=SxQJ
-----END PGP SIGNATURE-----