From: Avi Kivity <avi@qumranet.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
shaohua.li@intel.com, rusty@rustcorp.com.au,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH 1/3] SCHED: Generic hooks for trapping task preemption
Date: Wed, 25 Jul 2007 16:13:55 +0300 [thread overview]
Message-ID: <46A74C93.7080705@qumranet.com> (raw)
In-Reply-To: <20070725125220.GA8914@elte.hu>
Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
>
>
>>> This adds a general mechanism whereby a task can request the
>>> scheduler to notify it whenever it is preempted or scheduled back
>>> in. This allows the task to swap any special-purpose registers like
>>> the fpu or Intel's VT registers.
>>>
>> ok, this looks very clean, i've added it to my scheduler tree. You've
>> tested this with KVM, on both 32-bit and 64-bit, correct?
>>
>
> note: i've done a hook -> notifier rename - 'hook' is way too generic
> sounding and also slightly loaded. (updated patch below)
>
>
Okay, both i386 and x86_64 are happy (with the missing 'next' argument
added, but with the old hook name).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH 1/3] SCHED: Generic hooks for trapping task preemption
Date: Wed, 25 Jul 2007 16:13:55 +0300 [thread overview]
Message-ID: <46A74C93.7080705@qumranet.com> (raw)
In-Reply-To: <20070725125220.GA8914-X9Un+BFzKDI@public.gmane.org>
Ingo Molnar wrote:
> * Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org> wrote:
>
>
>>> This adds a general mechanism whereby a task can request the
>>> scheduler to notify it whenever it is preempted or scheduled back
>>> in. This allows the task to swap any special-purpose registers like
>>> the fpu or Intel's VT registers.
>>>
>> ok, this looks very clean, i've added it to my scheduler tree. You've
>> tested this with KVM, on both 32-bit and 64-bit, correct?
>>
>
> note: i've done a hook -> notifier rename - 'hook' is way too generic
> sounding and also slightly loaded. (updated patch below)
>
>
Okay, both i386 and x86_64 are happy (with the missing 'next' argument
added, but with the old hook name).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-07-25 13:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 12:43 [PATCH 0/3] Scheduler preemption hooks, #2 Avi Kivity
2007-07-25 12:43 ` Avi Kivity
2007-07-25 12:43 ` [PATCH 1/3] SCHED: Generic hooks for trapping task preemption Avi Kivity
2007-07-25 12:43 ` Avi Kivity
2007-07-25 12:49 ` Avi Kivity
2007-07-25 12:49 ` Avi Kivity
2007-07-25 12:49 ` Ingo Molnar
2007-07-25 12:49 ` Ingo Molnar
2007-07-25 12:51 ` Avi Kivity
2007-07-25 12:52 ` Ingo Molnar
2007-07-25 13:13 ` Avi Kivity [this message]
2007-07-25 13:13 ` Avi Kivity
2007-07-25 13:03 ` Ingo Molnar
2007-07-25 12:43 ` [PATCH 2/3] KVM: Use the scheduler preemption hooks to make kvm preemptible Avi Kivity
2007-07-25 12:43 ` Avi Kivity
2007-07-25 12:43 ` [PATCH 3/3] KVM: Convert vm lock to a mutex Avi Kivity
2007-07-25 12:43 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A74C93.7080705@qumranet.com \
--to=avi@qumranet.com \
--cc=ak@suse.de \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.