From: Patrick McHardy <kaber@trash.net>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: netfilter-devel@lists.netfilter.org, Marc Boucher <marc@mbsi.ca>,
Harald Welte <laforge@netfilter.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
James Morris <jmorris@namei.org>,
coreteam@netfilter.org,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH][netfilter] Avoid a possible NULL pointer deref in recent_seq_open()
Date: Mon, 30 Jul 2007 14:28:18 +0200 [thread overview]
Message-ID: <46ADD962.4040700@trash.net> (raw)
In-Reply-To: <200707290308.45464.jesper.juhl@gmail.com>
Jesper Juhl wrote:
> There is a small problem in
> net/ipv4/netfilter/ipt_recent.c::recent_seq_open().
>
> If the call to seq_open() returns != 0 then the code calls
> kfree(st) but then on the very next line proceeds to
> dereference the pointer - not good.
Applied, thanks Jesper.
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netfilter-devel@lists.netfilter.org, coreteam@netfilter.org,
Rusty Russell <rusty@rustcorp.com.au>,
Marc Boucher <marc@mbsi.ca>, James Morris <jmorris@namei.org>,
Harald Welte <laforge@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH][netfilter] Avoid a possible NULL pointer deref in recent_seq_open()
Date: Mon, 30 Jul 2007 14:28:18 +0200 [thread overview]
Message-ID: <46ADD962.4040700@trash.net> (raw)
In-Reply-To: <200707290308.45464.jesper.juhl@gmail.com>
Jesper Juhl wrote:
> There is a small problem in
> net/ipv4/netfilter/ipt_recent.c::recent_seq_open().
>
> If the call to seq_open() returns != 0 then the code calls
> kfree(st) but then on the very next line proceeds to
> dereference the pointer - not good.
Applied, thanks Jesper.
next prev parent reply other threads:[~2007-07-30 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 1:08 [PATCH][netfilter] Avoid a possible NULL pointer deref in recent_seq_open() Jesper Juhl
2007-07-30 12:28 ` Patrick McHardy [this message]
2007-07-30 12:28 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ADD962.4040700@trash.net \
--to=kaber@trash.net \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=jesper.juhl@gmail.com \
--cc=jmorris@namei.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=laforge@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@mbsi.ca \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.