From: Jeff Garzik <jeff@garzik.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Raisch <raisch@de.ibm.com>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Jan-Bernd Themann <ossthema@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>,
Andrew Gallatin <gallatin@myri.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile
Date: Mon, 30 Jul 2007 12:36:19 -0400 [thread overview]
Message-ID: <46AE1383.3050305@garzik.org> (raw)
In-Reply-To: <20070730172535.15993806@oldman.hamilton.local>
Stephen Hemminger wrote:
> Why make this a user selectable option at all? Unless you want
> to deal with out of tree drivers (not my problem), it should be hidden
> to avoid having to explain an support it.
In this case it's an optional library kernel module. That seems to be a
common setup for library modules. We do the same with CONFIG_MII and
drivers/net/mii.ko as well.
Originally it was done purely in the Makefile, but that does not account
for net drivers in sub-directories (or out of tree as you point out).
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Jan-Bernd Themann <ossthema@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
Christoph Raisch <raisch@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Marcus Eder <meder@de.ibm.com>, Thomas Klein <tklein@de.ibm.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>,
David Miller <davem@davemloft.net>,
Andrew Gallatin <gallatin@myri.com>
Subject: Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile
Date: Mon, 30 Jul 2007 12:36:19 -0400 [thread overview]
Message-ID: <46AE1383.3050305@garzik.org> (raw)
In-Reply-To: <20070730172535.15993806@oldman.hamilton.local>
Stephen Hemminger wrote:
> Why make this a user selectable option at all? Unless you want
> to deal with out of tree drivers (not my problem), it should be hidden
> to avoid having to explain an support it.
In this case it's an optional library kernel module. That seems to be a
common setup for library modules. We do the same with CONFIG_MII and
drivers/net/mii.ko as well.
Originally it was done purely in the Makefile, but that does not account
for net drivers in sub-directories (or out of tree as you point out).
Jeff
next prev parent reply other threads:[~2007-07-30 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 15:24 [PATCH 2/4][RFC] lro: Kconfig and Makefile Jan-Bernd Themann
2007-07-30 15:24 ` Jan-Bernd Themann
2007-07-30 16:25 ` Stephen Hemminger
2007-07-30 16:25 ` Stephen Hemminger
2007-07-30 16:36 ` Jeff Garzik [this message]
2007-07-30 16:36 ` Jeff Garzik
2007-07-30 17:00 ` Kok, Auke
2007-07-30 17:00 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AE1383.3050305@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=shemminger@linux-foundation.org \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.