[PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile

[PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile

[Nico Erfurth]

This patch adds the new iowarrior module to the Makefile in drivers/usb.
Currently the module isn't build unless another driver from usb/misc is
selected.

Signed-off-by: Nico Erfurth <masta@perlgolf.de>
---
--- linux/drivers/usb/Makefile.orig     2007-08-02 21:54:16.000000000 +0200
+++ linux/drivers/usb/Makefile  2007-08-02 22:20:57.000000000 +0200
@@ -38,6 +38,7 @@ obj-$(CONFIG_USB_EMI26)               += misc/
 obj-$(CONFIG_USB_EMI62)                += misc/
 obj-$(CONFIG_USB_FTDI_ELAN)    += misc/
 obj-$(CONFIG_USB_IDMOUSE)      += misc/
+obj-$(CONFIG_USB_IOWARRIOR)    += misc/
 obj-$(CONFIG_USB_LCD)          += misc/
 obj-$(CONFIG_USB_LD)           += misc/
 obj-$(CONFIG_USB_LED)          += misc/

Re: [PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile

[Sam Ravnborg]

On Thu, Aug 02, 2007 at 10:25:20PM +0200, Nico Erfurth wrote:
> This patch adds the new iowarrior module to the Makefile in drivers/usb.
> Currently the module isn't build unless another driver from usb/misc is
> selected.

Can we please just always vist misc like this:
obj-y := misc/

Then we do not need to repeat this stuff in both
drivers/usb/Makefile and drivers/usb/misc/Makefile

Thanks,
	Sam

Re: [PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile

[Greg KH]

On Thu, Aug 02, 2007 at 11:27:01PM +0200, Sam Ravnborg wrote:
> On Thu, Aug 02, 2007 at 10:25:20PM +0200, Nico Erfurth wrote:
> > This patch adds the new iowarrior module to the Makefile in drivers/usb.
> > Currently the module isn't build unless another driver from usb/misc is
> > selected.
> 
> Can we please just always vist misc like this:
> obj-y := misc/
> 
> Then we do not need to repeat this stuff in both
> drivers/usb/Makefile and drivers/usb/misc/Makefile

For some reason, we didn't do that because people were upset at us going
into these directories when they didn't have any usb misc devices
selected?  Or something like that, I really can't remember anymore.

But if you think it would be best to do that, I'd be glad to make the
change.

thanks,

greg k-h

Re: [PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile

[Sam Ravnborg]

On Mon, Aug 06, 2007 at 08:01:56PM -0700, Greg KH wrote:
> On Thu, Aug 02, 2007 at 11:27:01PM +0200, Sam Ravnborg wrote:
> > On Thu, Aug 02, 2007 at 10:25:20PM +0200, Nico Erfurth wrote:
> > > This patch adds the new iowarrior module to the Makefile in drivers/usb.
> > > Currently the module isn't build unless another driver from usb/misc is
> > > selected.
> > 
> > Can we please just always vist misc like this:
> > obj-y := misc/
> > 
> > Then we do not need to repeat this stuff in both
> > drivers/usb/Makefile and drivers/usb/misc/Makefile
> 
> For some reason, we didn't do that because people were upset at us going
> into these directories when they didn't have any usb misc devices
> selected?  Or something like that, I really can't remember anymore.
> 
> But if you think it would be best to do that, I'd be glad to make the
> change.
Please do - we have too much duplication between the two files now.

	Sam