[PATCH] Syntax error in iptables.xslt

[PATCH] Syntax error in iptables.xslt

[Dan Nicholson]

Using the iptables.xslt stylesheet as shipped in iptables-1.3.8 is causing
syntax errors when run through xsltproc.

$ echo | xsltproc iptables.xslt -
compilation error: file iptables.xslt line 118 element param
The value '$node' of the attribute 'name' is not a valid QName.
$ xsltproc --version
Using libxml 20627, libxslt 10120 and libexslt 813
xsltproc was compiled against libxml 20627, libxslt 10120 and libexslt 813
libxslt 10120 was compiled against libxml 20627
libexslt 813 was compiled against libxml 20627

The problem is that in <xsl:param name="$node"/>, "$node" is not a valid
QName.

http://www.w3.org/TR/xslt#variables

Patch below converts to a valid name and the one expected in the rest of
the stylesheet when using <xsl:with-param name="node"/>.

--
Dan

Index: iptables.xslt
===================================================================
--- iptables.xslt	(revision 6982)
+++ iptables.xslt	(working copy)
@@ -116,7 +116,7 @@
   </xsl:template>
   
   <xsl:template name="counters">
-    <xsl:param name="$node"/>
+    <xsl:param name="node"/>
     <xsl:text>[</xsl:text>
     <xsl:if test="string-length($node/@packet-count)"><xsl:value-of select="$node/@packet-count"/></xsl:if>
     <xsl:if test="string-length($node/@packet-count)=0">0</xsl:if>

[PATCH] Syntax error in iptables.xslt

[Dan Nicholson]

Using the iptables.xslt stylesheet as shipped in iptables-1.3.8 is causing
syntax errors when run through xsltproc.

$ echo | xsltproc iptables.xslt -
compilation error: file iptables.xslt line 118 element param
The value '$node' of the attribute 'name' is not a valid QName.
$ xsltproc --version
Using libxml 20627, libxslt 10120 and libexslt 813
xsltproc was compiled against libxml 20627, libxslt 10120 and libexslt 813
libxslt 10120 was compiled against libxml 20627
libexslt 813 was compiled against libxml 20627

The problem is that in <xsl:param name="$node"/>, "$node" is not a valid
QName.

http://www.w3.org/TR/xslt#variables

Patch below converts to a valid name and the one expected in the rest of
the stylesheet when using <xsl:with-param name="node"/>.

--
Dan

Index: iptables.xslt
===================================================================
--- iptables.xslt	(revision 6982)
+++ iptables.xslt	(working copy)
@@ -116,7 +116,7 @@
   </xsl:template>
   
   <xsl:template name="counters">
-    <xsl:param name="$node"/>
+    <xsl:param name="node"/>
     <xsl:text>[</xsl:text>
     <xsl:if test="string-length($node/@packet-count)"><xsl:value-of select="$node/@packet-count"/></xsl:if>
     <xsl:if test="string-length($node/@packet-count)=0">0</xsl:if>

Re: [PATCH] Syntax error in iptables.xslt

[Amin Azez]

* Dan Nicholson wrote, On 02/08/07 16:42:
> Patch below converts to a valid name and the one expected in the rest of
> the stylesheet when using <xsl:with-param name="node"/>.
> 
> --
> Dan
> 
> Index: iptables.xslt
> ===================================================================
> --- iptables.xslt	(revision 6982)
> +++ iptables.xslt	(working copy)
> @@ -116,7 +116,7 @@
>    </xsl:template>
>    
>    <xsl:template name="counters">
> -    <xsl:param name="$node"/>
> +    <xsl:param name="node"/>
>      <xsl:text>[</xsl:text>
>      <xsl:if test="string-length($node/@packet-count)"><xsl:value-of select="$node/@packet-count"/></xsl:if>
>      <xsl:if test="string-length($node/@packet-count)=0">0</xsl:if>
> 
> 

Thanks for spotting that. It would have had the effect of not restoring
counters.

Patrick, please accept this patch.

Signed-off by: Sam Liddicott <azez@ufomechanic.net>

Sam

Re: [PATCH] Syntax error in iptables.xslt

[Pablo Neira Ayuso]

Dan Nicholson wrote:
> The problem is that in <xsl:param name="$node"/>, "$node" is not a valid
> QName.
> 
> http://www.w3.org/TR/xslt#variables
> 
> Patch below converts to a valid name and the one expected in the rest of
> the stylesheet when using <xsl:with-param name="node"/>.

Applied, thanks Dan.

-- 
"Será preciso viajar a través de los ojos de los idiotas" -- Poeta en
Nueva York -- Federico García Lorca.