[PATCH] Fixup kpartx rules for dmraid

[PATCH] Fixup kpartx rules for dmraid

[Hannes Reinecke]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi Christophe,

the kpartx rules do not detect dmraid properly. This patch
fixes this.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

[-- Attachment #2: kpartx-fix-rules-for-dmraid --]
[-- Type: text/plain, Size: 975 bytes --]

[kpartx] Fix udev rules for dmraid

The kpartx_id program is located under /lib/udev, so we don't need to
call it with the full pathname.
And we should also create persistent links for dmraid tables.

Signed-off-by: Hannes Reinecke <hare@suse.de>

diff --git a/kpartx/kpartx.rules b/kpartx/kpartx.rules
index f32c718..9ab9a49 100644
--- a/kpartx/kpartx.rules
+++ b/kpartx/kpartx.rules
@@ -9,7 +9,7 @@ ACTION=="remove", GOTO="kpartx_end"
 
 ENV{DM_TABLE_STATE}!="LIVE", GOTO="kpartx_end"
 
-ENV{DM_UUID}=="?*", IMPORT{program}=="/lib/udev/kpartx_id %M %m $env{DM_UUID}"
+ENV{DM_UUID}=="?*", IMPORT{program}=="kpartx_id %M %m $env{DM_UUID}"
 
 OPTIONS="link_priority=50"
 
@@ -18,7 +18,7 @@ ENV{DM_UUID}=="mpath-*", \
 	SYMLINK+="disk/by-id/$env{DM_TYPE}-$env{DM_NAME}"
 
 # Create persistent links for dmraid tables
-ENV{DM_UUID}=="mpath-*", \
+ENV{DM_UUID}=="dmraid-*", \
         SYMLINK+="disk/by-id/$env{DM_TYPE}-$env{DM_NAME}"
 
 # Create persistent links for partitions

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] Fixup kpartx rules for dmraid

[Guido Guenther]

On Mon, Aug 06, 2007 at 01:22:27PM +0200, Hannes Reinecke wrote:
> -ENV{DM_UUID}=="?*", IMPORT{program}=="/lib/udev/kpartx_id %M %m $env{DM_UUID}"
> +ENV{DM_UUID}=="?*", IMPORT{program}=="kpartx_id %M %m $env{DM_UUID}"
/lib/udev/kpartx_id isn't in $PATH. This patch breaks the udev rule.
Cheers,
 -- Guido> 

Re: [PATCH] Fixup kpartx rules for dmraid

[Hannes Reinecke]

Guido Guenther wrote:
> On Mon, Aug 06, 2007 at 01:22:27PM +0200, Hannes Reinecke wrote:
>> -ENV{DM_UUID}=="?*", IMPORT{program}=="/lib/udev/kpartx_id %M %m $env{DM_UUID}"
>> +ENV{DM_UUID}=="?*", IMPORT{program}=="kpartx_id %M %m $env{DM_UUID}"
> /lib/udev/kpartx_id isn't in $PATH. This patch breaks the udev rule.

And /lib/udev is the standard path prefix since udev-0.89.

So?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

Re: [PATCH] Fixup kpartx rules for dmraid

[Guido Guenther]

On Tue, Aug 07, 2007 at 08:06:47AM +0200, Hannes Reinecke wrote:
> Guido Guenther wrote:
> > On Mon, Aug 06, 2007 at 01:22:27PM +0200, Hannes Reinecke wrote:
> >> -ENV{DM_UUID}=="?*", IMPORT{program}=="/lib/udev/kpartx_id %M %m $env{DM_UUID}"
> >> +ENV{DM_UUID}=="?*", IMPORT{program}=="kpartx_id %M %m $env{DM_UUID}"
> > /lib/udev/kpartx_id isn't in $PATH. This patch breaks the udev rule.
> 
> And /lib/udev is the standard path prefix since udev-0.89.
Ahh...right, IMPORT prefixes with /lib/udev, didn't know that, but it's
actually in the changelog. Sorry.
 -- Guido