[PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

[PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

[Aurelien Jarno]

The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to 
Kconfig.

Cc: Michael Buesch <mb@bu3sch.de>
Cc: Waldemar Brodkorb <wbx@openwrt.org>
Cc: Felix Fietkau <nbd@openwrt.org>
Cc: Florian Schirmer <jolt@tuxbox.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -38,6 +38,22 @@
 	  Lemote Fulong mini-PC board based on the Chinese Loongson-2E CPU and
 	  an FPGA northbridge
 
+config BCM947XX
+	bool "Support for BCM947xx based boards"
+	select DMA_NONCOHERENT
+	select HW_HAS_PCI
+	select IRQ_CPU
+	select SYS_HAS_CPU_MIPS32_R1
+	select SYS_SUPPORTS_32BIT_KERNEL
+	select SYS_SUPPORTS_LITTLE_ENDIAN
+	select SSB
+	select SSB_SERIAL
+	select SSB_DRIVER_PCICORE
+	select SSB_PCICORE_HOSTMODE
+	select GENERIC_GPIO
+	help
+	 Support for BCM947xx based boards
+
 config MACH_ALCHEMY
 	bool "Alchemy processor based machines"
 
-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

[Michael Buesch]

On Monday 06 August 2007, Aurelien Jarno wrote:
> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to 
> Kconfig.
> 
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: Waldemar Brodkorb <wbx@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: Florian Schirmer <jolt@tuxbox.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -38,6 +38,22 @@
>  	  Lemote Fulong mini-PC board based on the Chinese Loongson-2E CPU and
>  	  an FPGA northbridge
>  
> +config BCM947XX
> +	bool "Support for BCM947xx based boards"
> +	select DMA_NONCOHERENT
> +	select HW_HAS_PCI

Not sure what this does.
My 47xx machines do _not_ have a PCI bus.

> +	select IRQ_CPU
> +	select SYS_HAS_CPU_MIPS32_R1
> +	select SYS_SUPPORTS_32BIT_KERNEL
> +	select SYS_SUPPORTS_LITTLE_ENDIAN
> +	select SSB
> +	select SSB_SERIAL
> +	select SSB_DRIVER_PCICORE
> +	select SSB_PCICORE_HOSTMODE

Shouldn't we leave the PCICORE an option instead of force selecting
it here?
My WRT54G doesn't have a (usable) PCI core. So it would work
without the driver for it.
Especially on the small WAP54G disabling PCIcore support could
be useful to reduce the kernel size.

> +	select GENERIC_GPIO
> +	help
> +	 Support for BCM947xx based boards
> +
>  config MACH_ALCHEMY
>  	bool "Alchemy processor based machines"
>  

Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

[Felix Fietkau]

Michael Buesch wrote:

> Shouldn't we leave the PCICORE an option instead of force selecting
> it here?
> My WRT54G doesn't have a (usable) PCI core. So it would work
> without the driver for it.
> Especially on the small WAP54G disabling PCIcore support could
> be useful to reduce the kernel size.
Yeah, leave it as an option, but I think a 'default y if BCM947XX' on
the PCICORE option would be reasonable, since many 47xx devices do have pci.

- Felix

Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

[Michael Buesch]

On Monday 06 August 2007, Felix Fietkau wrote:
> Michael Buesch wrote:
> 
> > Shouldn't we leave the PCICORE an option instead of force selecting
> > it here?
> > My WRT54G doesn't have a (usable) PCI core. So it would work
> > without the driver for it.
> > Especially on the small WAP54G disabling PCIcore support could
> > be useful to reduce the kernel size.
> Yeah, leave it as an option, but I think a 'default y if BCM947XX' on
> the PCICORE option would be reasonable, since many 47xx devices do have pci.

Yeah, probably a good idea.

Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

[Aurelien Jarno]

On Mon, Aug 06, 2007 at 08:24:53PM +0200, Michael Buesch wrote:
> On Monday 06 August 2007, Felix Fietkau wrote:
> > Michael Buesch wrote:
> > 
> > > Shouldn't we leave the PCICORE an option instead of force selecting
> > > it here?
> > > My WRT54G doesn't have a (usable) PCI core. So it would work
> > > without the driver for it.
> > > Especially on the small WAP54G disabling PCIcore support could
> > > be useful to reduce the kernel size.
> > Yeah, leave it as an option, but I think a 'default y if BCM947XX' on
> > the PCICORE option would be reasonable, since many 47xx devices do have pci.
> 
> Yeah, probably a good idea.
> 

I will send a new patch to fix that.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

[Aurelien Jarno]

Michael Buesch a écrit :
> On Monday 06 August 2007, Aurelien Jarno wrote:
>> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to 
>> Kconfig.
>>
>> Cc: Michael Buesch <mb@bu3sch.de>
>> Cc: Waldemar Brodkorb <wbx@openwrt.org>
>> Cc: Felix Fietkau <nbd@openwrt.org>
>> Cc: Florian Schirmer <jolt@tuxbox.org>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>>
>> --- a/arch/mips/Kconfig
>> +++ b/arch/mips/Kconfig
>> @@ -38,6 +38,22 @@
>>  	  Lemote Fulong mini-PC board based on the Chinese Loongson-2E CPU and
>>  	  an FPGA northbridge
>>  
>> +config BCM947XX
>> +	bool "Support for BCM947xx based boards"
>> +	select DMA_NONCOHERENT
>> +	select HW_HAS_PCI
> 
> Not sure what this does.
> My 47xx machines do _not_ have a PCI bus.

Without HW_HAS_PCI, it is not possible to enable the PCI bus, as it
depends on this variable. However having it defined, does not mean the
PCI bus has to be enabled.


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

[PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2)

[Aurelien Jarno]

The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to 
Kconfig and modify the SSB Kconfig to select SSB_PCICORE_HOSTMODE by
default with BCM947XX CPUs.

Cc: Michael Buesch <mb@bu3sch.de>
Cc: Waldemar Brodkorb <wbx@openwrt.org>
Cc: Felix Fietkau <nbd@openwrt.org>
Cc: Florian Schirmer <jolt@tuxbox.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -67,6 +67,20 @@
 	  note that a kernel built with this option selected will not be
 	  able to run on normal units.
 
+config BCM947XX
+	bool "BCM947xx based boards"
+	select DMA_NONCOHERENT
+	select HW_HAS_PCI
+	select IRQ_CPU
+	select SYS_HAS_CPU_MIPS32_R1
+	select SYS_SUPPORTS_32BIT_KERNEL
+	select SYS_SUPPORTS_LITTLE_ENDIAN
+	select SSB
+	select SSB_DRIVER_MIPS
+	select GENERIC_GPIO
+	help
+	 Support for BCM947xx based boards
+
 config MIPS_COBALT
 	bool "Cobalt Server"
 	select DMA_NONCOHERENT
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -67,6 +67,7 @@
 config SSB_PCICORE_HOSTMODE
 	bool "Hostmode support for SSB PCI core"
 	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
+	default y if BCM947XX
 	help
 	  PCIcore hostmode operation (external PCI bus).
 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2)

[Michael Buesch]

On Monday 06 August 2007 22:16:50 Aurelien Jarno wrote:
> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to 
> Kconfig and modify the SSB Kconfig to select SSB_PCICORE_HOSTMODE by
> default with BCM947XX CPUs.
> 
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: Waldemar Brodkorb <wbx@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: Florian Schirmer <jolt@tuxbox.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Acked-by: Michael Buesch <mb@bu3sch.de>

> 
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -67,6 +67,20 @@
>  	  note that a kernel built with this option selected will not be
>  	  able to run on normal units.
>  
> +config BCM947XX
> +	bool "BCM947xx based boards"
> +	select DMA_NONCOHERENT
> +	select HW_HAS_PCI
> +	select IRQ_CPU
> +	select SYS_HAS_CPU_MIPS32_R1
> +	select SYS_SUPPORTS_32BIT_KERNEL
> +	select SYS_SUPPORTS_LITTLE_ENDIAN
> +	select SSB
> +	select SSB_DRIVER_MIPS
> +	select GENERIC_GPIO
> +	help
> +	 Support for BCM947xx based boards
> +
>  config MIPS_COBALT
>  	bool "Cobalt Server"
>  	select DMA_NONCOHERENT
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -67,6 +67,7 @@
>  config SSB_PCICORE_HOSTMODE
>  	bool "Hostmode support for SSB PCI core"
>  	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
> +	default y if BCM947XX
>  	help
>  	  PCIcore hostmode operation (external PCI bus).
>  
> 



-- 
Greetings Michael.

Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2)

[Florian Schirmer]

Hi,

Aurelien Jarno wrote:
> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to 
> Kconfig and modify the SSB Kconfig to select SSB_PCICORE_HOSTMODE by
> default with BCM947XX CPUs.
>
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: Waldemar Brodkorb <wbx@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: Florian Schirmer <jolt@tuxbox.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
>   

Looks good!

Acked-by: Florian Schirmer <jolt@tuxbox.org>

Best,
  Florian



> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -67,6 +67,20 @@
>  	  note that a kernel built with this option selected will not be
>  	  able to run on normal units.
>  
> +config BCM947XX
> +	bool "BCM947xx based boards"
> +	select DMA_NONCOHERENT
> +	select HW_HAS_PCI
> +	select IRQ_CPU
> +	select SYS_HAS_CPU_MIPS32_R1
> +	select SYS_SUPPORTS_32BIT_KERNEL
> +	select SYS_SUPPORTS_LITTLE_ENDIAN
> +	select SSB
> +	select SSB_DRIVER_MIPS
> +	select GENERIC_GPIO
> +	help
> +	 Support for BCM947xx based boards
> +
>  config MIPS_COBALT
>  	bool "Cobalt Server"
>  	select DMA_NONCOHERENT
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -67,6 +67,7 @@
>  config SSB_PCICORE_HOSTMODE
>  	bool "Hostmode support for SSB PCI core"
>  	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
> +	default y if BCM947XX
>  	help
>  	  PCIcore hostmode operation (external PCI bus).
>  
>
>