[PATCH 3/3] reiserfs: fix memset byte count during resize

[PATCH 3/3] reiserfs: fix memset byte count during resize

[Jeff Mahoney]

 The following patch corrects the memset in reiserfs_resize to clear
 the memory allocated for the new bitmap info structs. Previously,
 it would clear the memory used by the old size. Depending on the
 contents of memory, this could cause incorrect caching behavior for
 bitmap blocks in the newly allocated area.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
 fs/reiserfs/resize.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/reiserfs/resize.c	2007-08-07 11:07:15.000000000 -0400
+++ b/fs/reiserfs/resize.c	2007-08-07 11:07:25.000000000 -0400
@@ -119,7 +119,7 @@ int reiserfs_resize(struct super_block *
 			return -ENOMEM;
 		}
 		memset(bitmap, 0,
-		       sizeof(struct reiserfs_bitmap_info) * SB_BMAP_NR(s));
+		       sizeof(struct reiserfs_bitmap_info) * bmap_nr_new);
 		for (i = 0; i < bmap_nr; i++)
 			bitmap[i] = old_bitmap[i];
 

-- 
Jeff Mahoney
SUSE Labs

[patch 0/3] reiserfs: support for file systems > 8 TiB

[Jeff Mahoney]

 Hi all -

 When I was integrating my reiserfsprogs patches into 3.6.20, I realized
 that it already understands larger bitmaps. Not only that, it zeroes them
 out just as my patches did. Since that revision has been released for
 nearly a year, I'd call that "standard."

 This set of patches should be the final one. Rather than caching the
 bitmap count in the superblock, we calculate it on the fly like
 reiserfsprogs does.

 I've integrated this patch set into the openSUSE 10.3 kernel, but I'm
 confident they'll survive some heavier testing.

 -Jeff

--
Jeff Mahoney
SUSE Labs

[patch 3/3] reiserfs: fix memset byte count during resize

[Jeff Mahoney]

[-- Attachment #1: reiserfs-fix-resize-meminit.diff --]
[-- Type: text/plain, Size: 899 bytes --]

 The following patch corrects the memset in reiserfs_resize to clear
 the memory allocated for the new bitmap info structs. Previously,
 it would clear the memory used by the old size. Depending on the
 contents of memory, this could cause incorrect caching behavior for
 bitmap blocks in the newly allocated area.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
 fs/reiserfs/resize.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/reiserfs/resize.c	2007-08-07 11:07:15.000000000 -0400
+++ b/fs/reiserfs/resize.c	2007-08-07 11:07:25.000000000 -0400
@@ -119,7 +119,7 @@ int reiserfs_resize(struct super_block *
 			return -ENOMEM;
 		}
 		memset(bitmap, 0,
-		       sizeof(struct reiserfs_bitmap_info) * SB_BMAP_NR(s));
+		       sizeof(struct reiserfs_bitmap_info) * bmap_nr_new);
 		for (i = 0; i < bmap_nr; i++)
 			bitmap[i] = old_bitmap[i];
 

-- 
Jeff Mahoney
SUSE Labs