netns34

netns34

[Eric W. Biederman]

Ok.  After a bunch of work I have my network namespace patches working
again against 2.6.23-rc2 or whatever is linus's latest.

I need to break out my sysctl work and send that separately.

I need to get veth in there and I need to get a patch to /sbin/ip
to work with Patrick McHardy's form of patches.

But I think I am quickly approaching the point where I will have
patches ready for merging.

Once I get sysctl sorted out I will start post a minimal patchset
for prereview and see where things go.

Hopefully my sysfs work finally sticks this time.

Eric

Re: netns34

[Eric W. Biederman]

ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) writes:

> Ok.  After a bunch of work I have my network namespace patches working
> again against 2.6.23-rc2 or whatever is linus's latest.
>
> I need to break out my sysctl work and send that separately.
>
> I need to get veth in there and I need to get a patch to /sbin/ip
> to work with Patrick McHardy's form of patches.
>
> But I think I am quickly approaching the point where I will have
> patches ready for merging.
>
> Once I get sysctl sorted out I will start post a minimal patchset
> for prereview and see where things go.
>
> Hopefully my sysfs work finally sticks this time.

And the important part the code will shortly be available at:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/linux-2.6-netns.git#netns/v2.6.23-rc2netns34

And also from the default head.

Eric

Re: netns34

[Benjamin Thery]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

Hi Eric,

I've cloned the repository and built the kernel.

Unshare support is broken. It misses a small change in sys_unshare()
to accept the CLONE_NEWNET flag.
I guess it should be added in commit "net: Add network namespace
clone & unshare support." (See attached patch below)

Also, have you removed the "sysfs interface support for moving devices 
between namespaces" on purpose?
Is there another way to move interfaces now?

Benjamin

Eric W. Biederman wrote:
> ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) writes:
> 
>> Ok.  After a bunch of work I have my network namespace patches working
>> again against 2.6.23-rc2 or whatever is linus's latest.
>>
>> I need to break out my sysctl work and send that separately.
>>
>> I need to get veth in there and I need to get a patch to /sbin/ip
>> to work with Patrick McHardy's form of patches.
>>
>> But I think I am quickly approaching the point where I will have
>> patches ready for merging.
>>
>> Once I get sysctl sorted out I will start post a minimal patchset
>> for prereview and see where things go.
>>
>> Hopefully my sysfs work finally sticks this time.
> 
> And the important part the code will shortly be available at:
> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/linux-2.6-netns.git#netns/v2.6.23-rc2netns34
> 
> And also from the default head.
> 
> Eric
> 
> 


-- 
B e n j a m i n   T h e r y  - BULL/DT/Open Software R&D

    http://www.bull.com

[-- Attachment #2: Fix-netns-unshare-support.patch --]
[-- Type: text/x-patch, Size: 664 bytes --]

Fix network namespace unshare support.
Add CLONE_NEWNET flag in sys_unshare().

Index: linux-2.6.23-rc2-netns34/kernel/fork.c
===================================================================
--- linux-2.6.23-rc2-netns34.orig/kernel/fork.c
+++ linux-2.6.23-rc2-netns34/kernel/fork.c
@@ -1608,7 +1608,8 @@ asmlinkage long sys_unshare(unsigned lon
 	err = -EINVAL;
 	if (unshare_flags & ~(CLONE_THREAD|CLONE_FS|CLONE_NEWNS|CLONE_SIGHAND|
 				CLONE_VM|CLONE_FILES|CLONE_SYSVSEM|
-				CLONE_NEWUTS|CLONE_NEWIPC|CLONE_NEWUSER))
+				CLONE_NEWUTS|CLONE_NEWIPC|CLONE_NEWUSER|
+				CLONE_NEWNET))
 		goto bad_unshare_out;
 
 	if ((err = unshare_thread(unshare_flags)))

[-- Attachment #3: Type: text/plain, Size: 206 bytes --]

_______________________________________________
Containers mailing list
Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linux-foundation.org/mailman/listinfo/containers

Re: netns34

[Eric W. Biederman]

Benjamin Thery <benjamin.thery-6ktuUTfB/bM@public.gmane.org> writes:

> Hi Eric,
>
> I've cloned the repository and built the kernel.
>
> Unshare support is broken. It misses a small change in sys_unshare()
> to accept the CLONE_NEWNET flag.
> I guess it should be added in commit "net: Add network namespace
> clone & unshare support." (See attached patch below)
>
> Also, have you removed the "sysfs interface support for moving devices between
> namespaces" on purpose?

More or less.

> Is there another way to move interfaces now?

I'm half way through the switch to using /bin/ip, and following of the
work the Patrick McHardy et all have doe.  The kernel side is there
(or it should be) but I haven't gotten the user space side built
and tested.

Migrating by exiting the namespace has worked well enough for testing
so I haven't worried about getting the user space side of things
working again.


Eric

Re: netns34

[Eric W. Biederman]

Benjamin Thery <benjamin.thery-6ktuUTfB/bM@public.gmane.org> writes:

> Hi Eric,
>
> I've cloned the repository and built the kernel.
>
> Unshare support is broken. It misses a small change in sys_unshare()
> to accept the CLONE_NEWNET flag.

Hmm.  I thought I had that but it should be easy enough to fix.
> I guess it should be added in commit "net: Add network namespace
> clone & unshare support." (See attached patch below)
>
> Also, have you removed the "sysfs interface support for moving devices between
> namespaces" on purpose?
> Is there another way to move interfaces now?

Weird.  I thought I had replaced that patch but when I looked closer
the replacement doesn't show up in my tree.  It's pretty straightforward
so I will make a stab at getting that back in there.

Eric

netns45

[Eric W. Biederman]

Ok just to keep everyone in sync.

I just uploaded a version of my netns tree up to kernel.org rebased
on top of what David Miller has just merged.

git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/linux-2.6-netns.git#netns/v2.6.23-rc5netns45

Once things have settled down a bit I will figure out what needs to be
sent next.

I will probably concentrate on my miscellaneous bug fixes and the
sysfs work.

Daniel if you guys have any bug fixes for me I will be happy to apply
them, so the don't get forgotten.

Eric

Re: netns45

[Daniel Lezcano]

Eric W. Biederman wrote:
> Ok just to keep everyone in sync.
> 
> I just uploaded a version of my netns tree up to kernel.org rebased
> on top of what David Miller has just merged.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/linux-2.6-netns.git#netns/v2.6.23-rc5netns45
> 
> Once things have settled down a bit I will figure out what needs to be
> sent next.
> 
> I will probably concentrate on my miscellaneous bug fixes and the
> sysfs work.
> 
> Daniel if you guys have any bug fixes for me I will be happy to apply
> them, so the don't get forgotten.

Thanks Eric for the update.

We checked with Benjamin all the fixes, a few are missing. Some of them 
are already sent and merged to net-2.6.24. We will port the missing ones 
to netns45 and send them to you asap.

Regards˙
	-- Daniel