From: Ben Guthro <bguthro@virtualiron.com>
To: Ky Srinivasan <ksrinivasan@novell.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: fully virtualized vista
Date: Wed, 08 Aug 2007 15:15:48 -0400 [thread overview]
Message-ID: <46BA1664.7000600@virtualiron.com> (raw)
In-Reply-To: <46B9CCD4.E57C.0030.0@novell.com>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
Patch is attached. Hope this helps
Ky Srinivasan wrote:
> Thanks Ben. I would be interested in the patch.
>
> K. Y
>
>
>>>> On Wed, Aug 8, 2007 at 2:42 PM, in message <46BA0E9B.6020305@virtualiron.com>,
>>>>
> Ben Guthro <bguthro@virtualiron.com> wrote:
>
>> There is a CRC bug in the RTL8139 implementation in the QEMU used in 3.1
>> There have been discussions of this on the QEMU list, as well.
>>
>> We have a patch for 3.1, but have not ported it forward to unstable yet,
>> since unstable is using a newer version of QEMU.
>>
>> If there is interest in seeing the 3.1 patch, I'd be happy to post it.
>>
>>
>>
>> Ky Srinivasan wrote:
>>
>>> I am having networking issues on fully virtualized Vista. Is this a known
>>>
>> issue.
>>
>>> K. Y
>>>
>>>
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> http://lists.xensource.com/xen-devel
>>>
>>>
>
>
>
[-- Attachment #2: qemu-rtl8139-crc.patch --]
[-- Type: text/x-patch, Size: 1014 bytes --]
diff -r 05858d742ba7 tools/ioemu/hw/rtl8139.c
--- a/tools/ioemu/hw/rtl8139.c Wed Jul 18 10:46:24 2007 -0400
+++ b/tools/ioemu/hw/rtl8139.c Wed Jul 18 10:46:30 2007 -0400
@@ -55,7 +55,7 @@
/* RTL8139 provides frame CRC with received packet, this feature seems to be
ignored by most drivers, disabled by default */
-//#define RTL8139_CALCULATE_RXCRC 1
+#define RTL8139_CALCULATE_RXCRC 1
/* Uncomment to enable on-board timer interrupts */
//#define RTL8139_ONBOARD_TIMER 1
@@ -1032,7 +1032,7 @@ static void rtl8139_do_receive(void *opa
/* write checksum */
#if defined (RTL8139_CALCULATE_RXCRC)
- val = cpu_to_le32(crc32(~0, buf, size));
+ val = cpu_to_le32(crc32(0, buf, size));
#else
val = 0;
#endif
@@ -1138,7 +1138,7 @@ static void rtl8139_do_receive(void *opa
/* write checksum */
#if defined (RTL8139_CALCULATE_RXCRC)
- val = cpu_to_le32(crc32(~0, buf, size));
+ val = cpu_to_le32(crc32(0, buf, size));
#else
val = 0;
#endif
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2007-08-08 19:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 18:29 fully virtualized vista Ky Srinivasan
2007-08-08 18:37 ` Mats Petersson
2007-08-08 19:03 ` Ky Srinivasan
2007-08-08 18:39 ` Tim Deegan
2007-08-08 19:02 ` Ky Srinivasan
2007-08-08 19:14 ` Tim Deegan
2007-08-08 20:05 ` Ky Srinivasan
2007-08-08 18:42 ` Ben Guthro
2007-08-08 19:13 ` Ky Srinivasan
2007-08-08 19:15 ` Ben Guthro [this message]
2007-08-08 19:13 ` Ky Srinivasan
2007-08-08 19:19 ` Tim Deegan
2007-08-08 19:23 ` Ben Guthro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BA1664.7000600@virtualiron.com \
--to=bguthro@virtualiron.com \
--cc=ksrinivasan@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.