All of lore.kernel.org
 help / color / mirror / Atom feed
* myri10ge net-2.6.24 build fix
@ 2007-08-09  7:11 David Miller
  2007-08-09 13:30 ` Andrew Gallatin
  0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2007-08-09  7:11 UTC (permalink / raw)
  To: netdev; +Cc: gallatin


I had to add the following patch to fix the build after
the LRO changes, I have no idea how you could have compile
tested that patch let alone done any real testing on it :-/

diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 4cc5e6f..0ac0610 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -93,6 +93,7 @@ MODULE_LICENSE("Dual BSD/GPL");
 #define MYRI10GE_EEPROM_STRINGS_SIZE 256
 #define MYRI10GE_MAX_SEND_DESC_TSO ((65536 / 2048) * 2)
 #define MYRI10GE_MAX_LRO_DESCRIPTORS 8
+#define MYRI10GE_LRO_MAX_PKTS 64
 
 #define MYRI10GE_NO_CONFIRM_DATA htonl(0xffffffff)
 #define MYRI10GE_NO_RESPONSE_RESULT 0xffffffff

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: myri10ge net-2.6.24 build fix
  2007-08-09  7:11 myri10ge net-2.6.24 build fix David Miller
@ 2007-08-09 13:30 ` Andrew Gallatin
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Gallatin @ 2007-08-09 13:30 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

David Miller wrote:
 > I had to add the following patch to fix the build after
 > the LRO changes, I have no idea how you could have compile
 > tested that patch let alone done any real testing on it :-/

Whoops.  I'm very sorry about that.  Future patches will be submitted
by our Linux guy, who knows the correct procedures. :)

FWIW, the patch I sent came from a script which filters our internal
driver (which I always work with), and that line was erroneously
filtered by the script we use to remove all the stuff you guys frown
on (like our LRO, compat shims for older kernels, optional support to
receive into skbs rather than pages, etc).  My testing was done with
our un-filtered upstream driver.

Since our driver specific LRO is now gone (hurray!), I removed the LRO
filtering, re-ran the filter script, and arrived at the same patch
you committed.

Thanks for fixing my mistake!

Drew



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-09 13:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-09  7:11 myri10ge net-2.6.24 build fix David Miller
2007-08-09 13:30 ` Andrew Gallatin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.