All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [LIBNFNETLINK] Fix endless loop on unknown netfilter attributes.
@ 2007-08-08 19:59 Marcus Sundberg
  2007-08-09 16:58 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Marcus Sundberg @ 2007-08-08 19:59 UTC (permalink / raw)
  To: Pablo Neira; +Cc: netfilter-devel

Hi!

[LIBNFNETLINK] Fix endless loop on unknown netfilter attributes.

This prevents an endless loop when nfnl_check_attributes() sees
an unknown attribute.

Signed-off-by: Marcus Sundberg <marcus@ingate.com>


--- libnfnetlink-0.0.30/src/libnfnetlink.c	2007/08/08 11:32:07
+++ libnfnetlink-0.0.30/src/libnfnetlink.c	2007/08/08 11:32:17
@@ -1129,6 +1129,7 @@ int nfnl_check_attributes(const struct n
  					 * the kernel which we don't understand
  					 * yet. We have to silently ignore this
  					 * for the sake of future compatibility */
+					attr = NFA_NEXT(attr, attrlen);
  					continue;
  				}
  				nfa[flavor - 1] = attr;

-- 
---------------------------------------+--------------------------
   Marcus Sundberg <marcus@ingate.com>  | Firewalls with SIP & NAT
  Software Developer, Ingate Systems AB |  http://www.ingate.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [LIBNFNETLINK] Fix endless loop on unknown netfilter attributes.
  2007-08-08 19:59 [PATCH] [LIBNFNETLINK] Fix endless loop on unknown netfilter attributes Marcus Sundberg
@ 2007-08-09 16:58 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2007-08-09 16:58 UTC (permalink / raw)
  To: Marcus Sundberg; +Cc: netfilter-devel

Marcus Sundberg wrote:
> [LIBNFNETLINK] Fix endless loop on unknown netfilter attributes.
> 
> This prevents an endless loop when nfnl_check_attributes() sees
> an unknown attribute.

Applied. Thanks Marcus.

-- 
"Será preciso viajar a través de los ojos de los idiotas" -- Poeta en
Nueva York -- Federico García Lorca.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-09 16:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-08 19:59 [PATCH] [LIBNFNETLINK] Fix endless loop on unknown netfilter attributes Marcus Sundberg
2007-08-09 16:58 ` Pablo Neira Ayuso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.