Re: [-mm PATCH 8/9] Memory controller add switch to control what type of pages to limit (v4)

[Balbir Singh <balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>]

YAMAMOTO Takashi wrote:
>> Choose if we want cached pages to be accounted or not. By default both
>> are accounted for. A new set of tunables are added.
>>
>> echo -n 1 > mem_control_type
>>
>> switches the accounting to account for only mapped pages
>>
>> echo -n 2 > mem_control_type
>>
>> switches the behaviour back
> 
> MEM_CONTAINER_TYPE_ALL is 3, not 2.
> 

Thanks, I'll fix the comment on the top.

> YAMAMOTO Takashi
> 
>> +enum {
>> +	MEM_CONTAINER_TYPE_UNSPEC = 0,
>> +	MEM_CONTAINER_TYPE_MAPPED,
>> +	MEM_CONTAINER_TYPE_CACHED,
>> +	MEM_CONTAINER_TYPE_ALL,
>> +	MEM_CONTAINER_TYPE_MAX,
>> +} mem_control_type;
>> +
>> +static struct mem_container init_mem_container;
> 
>> +	mem = rcu_dereference(mm->mem_container);
>> +	if (mem->control_type == MEM_CONTAINER_TYPE_ALL)
>> +		return mem_container_charge(page, mm);
>> +	else
>> +		return 0;


-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL