* [KJ] [PATCH] drivers/net/tokenring: Convert to generic boolean
@ 2007-08-14 0:07 ` Richard Knutsson
0 siblings, 0 replies; 4+ messages in thread
From: Richard Knutsson @ 2007-08-14 0:07 UTC (permalink / raw)
To: mikep; +Cc: netdev, kernel-janitors, linux-kernel, Richard Knutsson
Convert to generic boolean
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
Sent 2007-05-01, no replys
diff --git a/drivers/net/tokenring/ibmtr.c b/drivers/net/tokenring/ibmtr.c
index 1e8958e..0c69eaa 100644
--- a/drivers/net/tokenring/ibmtr.c
+++ b/drivers/net/tokenring/ibmtr.c
@@ -116,9 +116,6 @@ in the event that chatty debug messages are desired - jjs 12/30/98 */
#define ENABLE_PAGING 1
#endif
-#define FALSE 0
-#define TRUE (!FALSE)
-
/* changes the output format of driver initialization */
#define TR_VERBOSE 0
@@ -1542,7 +1539,7 @@ static void initial_tok_int(struct net_device *dev)
ti->ring_speed = init_status & 0x01 ? 16 : 4;
DPRINTK("Initial interrupt : %d Mbps, shared RAM base %08x.\n",
ti->ring_speed, (unsigned int)dev->mem_start);
- ti->auto_speedsave=readb(ti->init_srb+INIT_STATUS_2_OFST)&4?TRUE:FALSE;
+ ti->auto_speedsave = (readb(ti->init_srb+INIT_STATUS_2_OFST) & 4) != 0;
if (ti->open_mode = MANUAL) wake_up(&ti->wait_for_reset);
else tok_open_adapter((unsigned long)dev);
_______________________________________________
REMINDER: this mailing list moved to vger.kernel.org and current one will be discontinued soon.
To resubscribe, send email to majordomo@vger.kernel.org with
"subscribe kernel-janitors" in message body and follow instructions.
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drivers/net/tokenring: Convert to generic boolean
@ 2007-08-14 0:07 ` Richard Knutsson
0 siblings, 0 replies; 4+ messages in thread
From: Richard Knutsson @ 2007-08-14 0:07 UTC (permalink / raw)
To: mikep; +Cc: netdev, kernel-janitors, linux-kernel, Richard Knutsson
Convert to generic boolean
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
Sent 2007-05-01, no replys
diff --git a/drivers/net/tokenring/ibmtr.c b/drivers/net/tokenring/ibmtr.c
index 1e8958e..0c69eaa 100644
--- a/drivers/net/tokenring/ibmtr.c
+++ b/drivers/net/tokenring/ibmtr.c
@@ -116,9 +116,6 @@ in the event that chatty debug messages are desired - jjs 12/30/98 */
#define ENABLE_PAGING 1
#endif
-#define FALSE 0
-#define TRUE (!FALSE)
-
/* changes the output format of driver initialization */
#define TR_VERBOSE 0
@@ -1542,7 +1539,7 @@ static void initial_tok_int(struct net_device *dev)
ti->ring_speed = init_status & 0x01 ? 16 : 4;
DPRINTK("Initial interrupt : %d Mbps, shared RAM base %08x.\n",
ti->ring_speed, (unsigned int)dev->mem_start);
- ti->auto_speedsave=readb(ti->init_srb+INIT_STATUS_2_OFST)&4?TRUE:FALSE;
+ ti->auto_speedsave = (readb(ti->init_srb+INIT_STATUS_2_OFST) & 4) != 0;
if (ti->open_mode == MANUAL) wake_up(&ti->wait_for_reset);
else tok_open_adapter((unsigned long)dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [KJ] Re: [PATCH] drivers/net/tokenring: Convert to generic boolean
2007-08-14 0:07 ` Richard Knutsson
@ 2007-08-14 5:50 ` Jeff Garzik
-1 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-08-14 5:50 UTC (permalink / raw)
To: Richard Knutsson; +Cc: mikep, netdev, kernel-janitors, linux-kernel
Richard Knutsson wrote:
> Convert to generic boolean
>
> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
> ---
> Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
> Diffed against Linus' git-tree.
> Sent 2007-05-01, no replys
applied
_______________________________________________
REMINDER: this mailing list moved to vger.kernel.org and current one will be discontinued soon.
To resubscribe, send email to majordomo@vger.kernel.org with
"subscribe kernel-janitors" in message body and follow instructions.
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/net/tokenring: Convert to generic boolean
@ 2007-08-14 5:50 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-08-14 5:50 UTC (permalink / raw)
To: Richard Knutsson; +Cc: mikep, netdev, kernel-janitors, linux-kernel
Richard Knutsson wrote:
> Convert to generic boolean
>
> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
> ---
> Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
> Diffed against Linus' git-tree.
> Sent 2007-05-01, no replys
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-14 5:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-14 0:07 [KJ] [PATCH] drivers/net/tokenring: Convert to generic boolean Richard Knutsson
2007-08-14 0:07 ` Richard Knutsson
2007-08-14 5:50 ` [KJ] " Jeff Garzik
2007-08-14 5:50 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.