All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ps3: Fix no storage devices found
       [not found]       ` <46C1D0D6.7030403@am.sony.com>
@ 2007-08-14 16:30         ` Geert Uytterhoeven
  2007-08-14 16:39           ` Geoff Levand
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2007-08-14 16:30 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linux/PPC Development, Hiroyuki Machida, Olaf Hering

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1379 bytes --]

Fix probing of PS3 storage devices: in the success case, we should set `error'
to zero, not `result'.

Without this patch no storage devices are found.

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
---
This brown paper bag bug slipped in due to bad patch splitting.
Please apply as soon as possible. Thanks!

 arch/powerpc/platforms/ps3/device-init.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- a/arch/powerpc/platforms/ps3/device-init.c
+++ b/arch/powerpc/platforms/ps3/device-init.c
@@ -372,7 +372,7 @@ static int ps3_storage_wait_for_device(c
 		    notify_event->dev_type == repo->dev_type) {
 			pr_debug("%s:%u: device ready: dev_id %u\n", __func__,
 				 __LINE__, repo->dev_id);
-			result = 0;
+			error = 0;
 			break;
 		}
 

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven@sonycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ps3: Fix no storage devices found
  2007-08-14 16:30         ` [PATCH] ps3: Fix no storage devices found Geert Uytterhoeven
@ 2007-08-14 16:39           ` Geoff Levand
  0 siblings, 0 replies; 2+ messages in thread
From: Geoff Levand @ 2007-08-14 16:39 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linux/PPC Development, Hiroyuki Machida, Andrew Morton,
	Olaf Hering

Geert Uytterhoeven wrote:
> Fix probing of PS3 storage devices: in the success case, we should set `error'
> to zero, not `result'.
> 
> Without this patch no storage devices are found.
> 
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> ---
> This brown paper bag bug slipped in due to bad patch splitting.
> Please apply as soon as possible. Thanks!

Looks good.

Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-14 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <46C0FDC0.6000503@am.sony.com>
     [not found] ` <20070814123227.GA18886@suse.de>
     [not found]   ` <20070814143537.GA21308@suse.de>
     [not found]     ` <20070814152651.GA22182@suse.de>
     [not found]       ` <46C1D0D6.7030403@am.sony.com>
2007-08-14 16:30         ` [PATCH] ps3: Fix no storage devices found Geert Uytterhoeven
2007-08-14 16:39           ` Geoff Levand

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.