From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [RFC] restore netdev_priv optimization (planb)
Date: Fri, 17 Aug 2007 18:21:25 -0700 [thread overview]
Message-ID: <46C64995.4030401@intel.com> (raw)
In-Reply-To: <20070817.180006.98552435.davem@davemloft.net>
David Miller wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Fri, 17 Aug 2007 17:49:09 -0700
>
>> Fix optimization of netdev_priv() lost by the addition of multiqueue.
>>
>> Only configurations that define MULITQUEUE need the extra overhead in
>> netdevice structure and the loss of the netdev_priv optimization.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> Every distribution vendor is going to turn MULTIQUEUE on. Therefore
> %99 of Linux users will not see any gain from your patch.
>
> You're walking around in a dark room and hitting walls every
> few seconds. Take a moment and think about how to really deal
> with this generically for a second before churning out another
> patch.
>
> For example, how about making the multiqueue limit fixed, say at 64
> queues, and declare the egress_queues as an array of 64 entries. Then
> you can get constant pointer formation for both the netdev priv and
> the queues.
this sounds highly optimistic ("64 queues is enough for everyone"?) and probably
will be quickly outdated by both hardware and demand...
Auke
next prev parent reply other threads:[~2007-08-18 1:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 22:40 [RFC] restore netdev_priv optimization Stephen Hemminger
2007-08-17 23:04 ` David Miller
2007-08-17 23:19 ` Stephen Hemminger
2007-08-17 23:56 ` David Miller
2007-08-18 0:49 ` [RFC] restore netdev_priv optimization (planb) Stephen Hemminger
2007-08-18 1:00 ` David Miller
2007-08-18 1:21 ` Kok, Auke [this message]
2007-08-18 1:28 ` Stephen Hemminger
2007-08-18 1:31 ` David Miller
2007-08-18 1:30 ` David Miller
2007-08-18 1:48 ` Kok, Auke
2007-08-20 11:51 ` [RFC] restore netdev_priv optimization Benjamin Thery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C64995.4030401@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.