From: Benjamin Thery <benjamin.thery@bull.net>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org,
ebiederm@xmission.com
Subject: Re: [RFC] restore netdev_priv optimization
Date: Mon, 20 Aug 2007 13:51:37 +0200 [thread overview]
Message-ID: <46C98049.7060308@bull.net> (raw)
In-Reply-To: <20070817.160409.88475506.davem@davemloft.net>
Hi,
David Miller wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Fri, 17 Aug 2007 15:40:22 -0700
>
>> Compile tested only!!!
>
> Obviously. The first loopback transmit is guarenteed to crash.
>
> [...]
>
> And this also breaks loopback again, which uses a static struct netdev
> in the kernel image, it doesn't use alloc_netdev(), so egress_subqueue
> of loopback will be NULL.
Talking about loopback, don't you think it could be the right time
to make it behave like any other kind of net devices, and allocate it
dynamically.
Having a dynamically allocated loopback could make maintenance easier
(removing special cases).
Also this is something we'll need to support multiple loopbacks for
example for network namespaces.
Eric Biederman has written a nice patch that does this.
I'm using it on 2.6.23-rc2.
Benjamin
--
B e n j a m i n T h e r y - BULL/DT/Open Software R&D
http://www.bull.com
prev parent reply other threads:[~2007-08-20 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 22:40 [RFC] restore netdev_priv optimization Stephen Hemminger
2007-08-17 23:04 ` David Miller
2007-08-17 23:19 ` Stephen Hemminger
2007-08-17 23:56 ` David Miller
2007-08-18 0:49 ` [RFC] restore netdev_priv optimization (planb) Stephen Hemminger
2007-08-18 1:00 ` David Miller
2007-08-18 1:21 ` Kok, Auke
2007-08-18 1:28 ` Stephen Hemminger
2007-08-18 1:31 ` David Miller
2007-08-18 1:30 ` David Miller
2007-08-18 1:48 ` Kok, Auke
2007-08-20 11:51 ` Benjamin Thery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C98049.7060308@bull.net \
--to=benjamin.thery@bull.net \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.