From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Jarek Poplawski <jarkao2@o2.pl>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
len.brown@intel.com, Andrew Morton <akpm@osdl.org>
Subject: Re: [Git Patch] ACPI: Fix a warning of discarding qualifiers from pointer target type
Date: Tue, 21 Aug 2007 19:14:49 +0400 [thread overview]
Message-ID: <46CB0169.7090207@suse.de> (raw)
In-Reply-To: <20070821150714.GA7591@hacking>
WANG Cong wrote:
> Fix this warning:
>
> drivers/acpi/ec.c: In function `acpi_ec_ecdt_probe':
> drivers/acpi/ec.c:873: warning: passing arg 1 of `acpi_get_devices' discards qualifiers from pointer target type
>
> (I don't know whether this fix hits the real problem.)
>
It is safe to give acpi_get_devices() const string, as it should not
modify it in any condition.
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
>
ACK
Thanks,
Alex
> ---
> drivers/acpi/ec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6.23-rc3-git3/drivers/acpi/ec.c
> ===================================================================
> --- linux-2.6.23-rc3-git3.orig/drivers/acpi/ec.c
> +++ linux-2.6.23-rc3-git3/drivers/acpi/ec.c
> @@ -869,8 +869,8 @@ int __init acpi_ec_ecdt_probe(void)
> boot_ec->handle = ACPI_ROOT_OBJECT;
> } else {
> printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
> - status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
> - boot_ec, NULL);
> + status = acpi_get_devices((char *)ec_device_ids[0].id,
> + ec_parse_device, boot_ec, NULL);
> if (ACPI_FAILURE(status))
> goto error;
> }
>
next prev parent reply other threads:[~2007-08-21 15:15 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 13:20 2.6.23-rc3-git3 make warnings Jarek Poplawski
2007-08-21 15:07 ` [Git Patch] ACPI: Fix a warning of discarding qualifiers from pointer target type WANG Cong
2007-08-21 15:14 ` Alexey Starikovskiy [this message]
2007-08-21 15:18 ` Al Viro
2007-08-21 15:22 ` Alexey Starikovskiy
2007-08-21 15:47 ` Al Viro
2007-08-23 0:59 ` Brown, Len
2007-08-23 0:59 ` Brown, Len
2007-08-23 1:28 ` Al Viro
2007-08-22 7:57 ` Jarek Poplawski
2007-08-21 16:17 ` 2.6.23-rc3-git3 make warnings WANG Cong
2007-08-21 16:44 ` Greg KH
2007-08-21 16:57 ` Adrian Bunk
2007-08-21 16:57 ` Adrian Bunk
2007-08-21 16:31 ` Randy Dunlap
2007-08-21 17:35 ` RFC: drop support for gcc < 4.0 Adrian Bunk
2007-08-21 17:54 ` Russell King
2007-08-21 17:54 ` Russell King
2007-08-21 18:14 ` Kyle McMartin
2007-08-21 18:29 ` Adrian Bunk
2007-08-22 5:48 ` Robert P. J. Day
2007-08-21 18:25 ` Chris Wedgwood
2007-08-21 20:41 ` Glauber de Oliveira Costa
2007-08-21 20:56 ` Segher Boessenkool
2007-08-21 21:01 ` Glauber de Oliveira Costa
2007-08-22 6:59 ` Thomas Bogendoerfer
2007-08-22 18:15 ` Ralf Baechle
2007-08-21 19:19 ` Andi Kleen
2007-08-21 19:54 ` Adrian Bunk
2007-08-21 20:07 ` [RFC][PATCH] introduce TASK_SIZE_OF() for all arches Matthew Wilcox
2007-08-21 20:08 ` RFC: drop support for gcc < 4.0 Linus Torvalds
2007-08-21 20:21 ` Adrian Bunk
2007-08-21 20:32 ` Linus Torvalds
2007-08-22 7:36 ` Jarek Poplawski
2007-08-21 20:49 ` Segher Boessenkool
2007-08-21 21:21 ` Adrian Bunk
2007-08-21 21:49 ` James Bottomley
2007-08-21 22:09 ` Adrian Bunk
2007-08-22 0:08 ` Segher Boessenkool
2007-08-22 6:07 ` Jarek Poplawski
2007-08-21 21:41 ` Oliver Pinter
2007-08-22 7:57 ` Jan Engelhardt
2007-08-22 8:08 ` Jarek Poplawski
2007-08-22 8:10 ` Jan Engelhardt
2007-08-22 8:42 ` Michal Piotrowski
2007-08-22 8:56 ` Jarek Poplawski
2007-08-22 8:48 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CB0169.7090207@suse.de \
--to=astarikovskiy@suse.de \
--cc=akpm@osdl.org \
--cc=jarkao2@o2.pl \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.