From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jiri Slaby <jirislaby@gmail.com>,
postfail@hushmail.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
Date: Fri, 24 Aug 2007 20:03:42 +0000 [thread overview]
Message-ID: <46CF399E.3010808@gmail.com> (raw)
In-Reply-To: <20070824201530.5d741b37@the-village.bc.nu>
Alan Cox napsal(a):
> ase, 0x80);
>> remove also the hwbase var.
>>
>>> + rebase = pci_iomap(pdev, 0, 0x80);
>>> t = readl(rebase + CNTRL_REG_OFFSET);
>
> Switch to ioread* if you are using the iomap interface. Its not a trivial
Why, if you know it's surely a mem region (and thus you rely on it and do
ioremap)? There are many places in the kernel, where this approach is used, e.g.
libata piix.
> conversion and its slower and bulkier - the original ioremap was much
> better
at least get rid of the reading the hwbase address from pci conf space, use
pci_resource_start instead.
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jiri Slaby <jirislaby@gmail.com>,
postfail@hushmail.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
Date: Fri, 24 Aug 2007 22:03:42 +0200 [thread overview]
Message-ID: <46CF399E.3010808@gmail.com> (raw)
In-Reply-To: <20070824201530.5d741b37@the-village.bc.nu>
Alan Cox napsal(a):
> ase, 0x80);
>> remove also the hwbase var.
>>
>>> + rebase = pci_iomap(pdev, 0, 0x80);
>>> t = readl(rebase + CNTRL_REG_OFFSET);
>
> Switch to ioread* if you are using the iomap interface. Its not a trivial
Why, if you know it's surely a mem region (and thus you rely on it and do
ioremap)? There are many places in the kernel, where this approach is used, e.g.
libata piix.
> conversion and its slower and bulkier - the original ioremap was much
> better
at least get rid of the reading the hwbase address from pci conf space, use
pci_resource_start instead.
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University
next prev parent reply other threads:[~2007-08-24 20:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 18:49 [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api Scott Thompson
2007-08-24 18:49 ` Scott Thompson
2007-08-24 18:59 ` Jiri Slaby
2007-08-24 18:59 ` Jiri Slaby
2007-08-24 19:15 ` Alan Cox
2007-08-24 19:15 ` Alan Cox
2007-08-24 20:03 ` Jiri Slaby [this message]
2007-08-24 20:03 ` Jiri Slaby
2007-08-24 20:34 ` Alan Cox
2007-08-24 20:34 ` Alan Cox
2007-08-25 8:45 ` readXs on pci*iomap-ped regions [Was: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api] Jiri Slaby
2007-08-25 8:56 ` Jeff Garzik
2007-08-25 9:02 ` Jiri Slaby
2007-08-25 10:17 ` Alan Cox
2007-08-24 19:31 ` [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api Scott Thompson
2007-08-24 19:31 ` Scott Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CF399E.3010808@gmail.com \
--to=jirislaby@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=postfail@hushmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.