From: Michael Kerrisk <mtk-manpages@gmx.net>
To: Nicolas George <nicolas.george@ens.fr>
Cc: jdike@linux.intel.com, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] UML/man: BLKGETSIZE takes a long, not an int
Date: Mon, 27 Aug 2007 15:25:54 +0200 [thread overview]
Message-ID: <46D2D0E2.9060408@gmx.net> (raw)
In-Reply-To: <20070814092942.GA14324@clipper.ens.fr>
Hello Nicolas,
> I fear that my bug-report yesterday was very badly written, with me writing
> to the wrong mailing-list and all.
>
> I was saying:
>
>> I found a type mismatch in UML that makes host block devices unusable as ubd
>> devices on x86_64 and other 64 bits systems (segfault of the mm subsystem):
>>
>> In block/ioctl.c, the following lines show that the BLKGETSIZE ioctl expects
>> a pointer to a long:
>>
>> case BLKGETSIZE:
>> if ((bdev->bd_inode->i_size >> 9) > ~0UL)
>> return -EFBIG;
>> return put_ulong(arg, bdev->bd_inode->i_size >> 9);
>>
>> In arch/um/os-Linux/file.c, os_file_size calls it with an int.
>>
>> The ioctl_list man page should be fixed as well.
manual page changed for 2.65:
--- ioctl_list.2
+++ ioctl_list.2 (working copy)
@@ -243,7 +243,7 @@
0x0000125D BLKROSET const int *
0x0000125E BLKROGET int *
0x0000125F BLKRRPART void
-0x00001260 BLKGETSIZE int *
+0x00001260 BLKGETSIZE unsigned long *
0x00001261 BLKFLSBUF void
0x00001262 BLKRASET int
0x00001263 BLKRAGET int *
Thanks,
Michael
--
Michael Kerrisk
maintainer of Linux man pages Sections 2, 3, 4, 5, and 7
Want to help with man page maintenance? Grab the latest tarball at
http://www.kernel.org/pub/linux/docs/manpages/
read the HOWTOHELP file and grep the source files for 'FIXME'.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Michael Kerrisk <mtk-manpages@gmx.net>
To: Nicolas George <nicolas.george@ens.fr>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
jdike@linux.intel.com
Subject: Re: UML/man: BLKGETSIZE takes a long, not an int
Date: Mon, 27 Aug 2007 15:25:54 +0200 [thread overview]
Message-ID: <46D2D0E2.9060408@gmx.net> (raw)
In-Reply-To: <20070814092942.GA14324@clipper.ens.fr>
Hello Nicolas,
> I fear that my bug-report yesterday was very badly written, with me writing
> to the wrong mailing-list and all.
>
> I was saying:
>
>> I found a type mismatch in UML that makes host block devices unusable as ubd
>> devices on x86_64 and other 64 bits systems (segfault of the mm subsystem):
>>
>> In block/ioctl.c, the following lines show that the BLKGETSIZE ioctl expects
>> a pointer to a long:
>>
>> case BLKGETSIZE:
>> if ((bdev->bd_inode->i_size >> 9) > ~0UL)
>> return -EFBIG;
>> return put_ulong(arg, bdev->bd_inode->i_size >> 9);
>>
>> In arch/um/os-Linux/file.c, os_file_size calls it with an int.
>>
>> The ioctl_list man page should be fixed as well.
manual page changed for 2.65:
--- ioctl_list.2
+++ ioctl_list.2 (working copy)
@@ -243,7 +243,7 @@
0x0000125D BLKROSET const int *
0x0000125E BLKROGET int *
0x0000125F BLKRRPART void
-0x00001260 BLKGETSIZE int *
+0x00001260 BLKGETSIZE unsigned long *
0x00001261 BLKFLSBUF void
0x00001262 BLKRASET int
0x00001263 BLKRAGET int *
Thanks,
Michael
--
Michael Kerrisk
maintainer of Linux man pages Sections 2, 3, 4, 5, and 7
Want to help with man page maintenance? Grab the latest tarball at
http://www.kernel.org/pub/linux/docs/manpages/
read the HOWTOHELP file and grep the source files for 'FIXME'.
next prev parent reply other threads:[~2007-08-27 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 9:29 Nicolas George
2007-08-27 13:25 ` Michael Kerrisk [this message]
2007-08-27 13:25 ` UML/man: BLKGETSIZE takes a long, not an int Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D2D0E2.9060408@gmx.net \
--to=mtk-manpages@gmx.net \
--cc=jdike@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.george@ens.fr \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.