Re: [PATCH 3/7] SUNRPC: RPC bind failures should be permanent for NULL requests

Re: [PATCH 3/7] SUNRPC: RPC bind failures should be permanent for NULL requests

[Chuck Lever]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

Trond Myklebust wrote:
> On Mon, 2007-08-27 at 13:30 -0400, Chuck Lever wrote:
>> The purpose of an RPC ping (a NULL request) is to determine whether the
>> remote end is operating and supports the program and version of the
>> request.
>>
>> If we do an RPC bind and the remote's rpcbind service says "this program or
>> service isn't supported" then we have our answer already, and we should
>> give up immediately.
>>
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
>>
>>  net/sunrpc/clnt.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
>> index 215bafa..4ebdfb8 100644
>> --- a/net/sunrpc/clnt.c
>> +++ b/net/sunrpc/clnt.c
>> @@ -947,6 +947,11 @@ call_bind_status(struct rpc_task *task)
>>  	case -EACCES:
>>  		dprintk("RPC: %5u remote rpcbind: RPC program/version "
>>  				"unavailable\n", task->tk_pid);
>> +		/* fail immediately if this is an RPC ping */
>> +		if (task->tk_msg.rpc_proc->p_proc == 0) {
>> +			task->tk_status = -ENOPROTOOPT;
>> +			break;
>> +		}
>>  		rpc_delay(task, 3*HZ);
>>  		goto retry_timeout;
>>  	case -ETIMEDOUT:
>>
> 
> The rpcbind client currently also returns EACCES if it simply wants us
> to retry the request. If you want to do something like the above,
> shouldn't you be distinguishing between the two cases?

The rpcb_getport_done() callback reports -EPROTONOSUPPORT if it wants to 
retry with another rpcbind version.  But I see the forward path 
(rpcb_getport_async) does use -EACCES for a retry -- I think that's an 
error and should be changed.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 290 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs