From: Jeff Garzik <jeff@garzik.org>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, rcjenn@linux.vnet.ibm.com,
santil@linux.vnet.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers
Date: Fri, 31 Aug 2007 09:14:36 -0400 [thread overview]
Message-ID: <46D8143C.9030603@garzik.org> (raw)
In-Reply-To: <200708171416.l7HEGbwx003958@d01av02.pok.ibm.com>
Brian King wrote:
> Add handlers for get_tso and get_ufo to prevent errors being printed
> by ethtool.
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
>
> linux-2.6-bjking1/drivers/net/ibmveth.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers/net/ibmveth.c
> --- linux-2.6/drivers/net/ibmveth.c~ibmveth_ethtool_get_tso 2007-08-08 10:46:28.000000000 -0500
> +++ linux-2.6-bjking1/drivers/net/ibmveth.c 2007-08-08 10:46:28.000000000 -0500
> @@ -767,6 +767,8 @@ static const struct ethtool_ops netdev_e
> .set_tx_csum = ibmveth_set_tx_csum,
> .get_rx_csum = ibmveth_get_rx_csum,
> .set_rx_csum = ibmveth_set_rx_csum,
> + .get_tso = ethtool_op_get_tso,
> + .get_ufo = ethtool_op_get_ufo,
This patch is fine, but I wonder if we shouldn't add some code to
net/core/ethtool.c along the lines of...
if (!netdev->ethtool_ops->get_tso)
ethtool_op_get_tso(args);
else
netdev->ethtool_ops->get_tso(args);
Because this certainly seems like desirable behavior across all devices.
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: santil@linux.vnet.ibm.com, rcjenn@linux.vnet.ibm.com,
netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers
Date: Fri, 31 Aug 2007 09:14:36 -0400 [thread overview]
Message-ID: <46D8143C.9030603@garzik.org> (raw)
In-Reply-To: <200708171416.l7HEGbwx003958@d01av02.pok.ibm.com>
Brian King wrote:
> Add handlers for get_tso and get_ufo to prevent errors being printed
> by ethtool.
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
>
> linux-2.6-bjking1/drivers/net/ibmveth.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers/net/ibmveth.c
> --- linux-2.6/drivers/net/ibmveth.c~ibmveth_ethtool_get_tso 2007-08-08 10:46:28.000000000 -0500
> +++ linux-2.6-bjking1/drivers/net/ibmveth.c 2007-08-08 10:46:28.000000000 -0500
> @@ -767,6 +767,8 @@ static const struct ethtool_ops netdev_e
> .set_tx_csum = ibmveth_set_tx_csum,
> .get_rx_csum = ibmveth_get_rx_csum,
> .set_rx_csum = ibmveth_set_rx_csum,
> + .get_tso = ethtool_op_get_tso,
> + .get_ufo = ethtool_op_get_ufo,
This patch is fine, but I wonder if we shouldn't add some code to
net/core/ethtool.c along the lines of...
if (!netdev->ethtool_ops->get_tso)
ethtool_op_get_tso(args);
else
netdev->ethtool_ops->get_tso(args);
Because this certainly seems like desirable behavior across all devices.
next prev parent reply other threads:[~2007-08-31 13:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 14:16 [PATCH 1/6] ibmveth: Enable TCP checksum offload Brian King
2007-08-17 14:16 ` [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable " Brian King
2007-08-17 14:16 ` Brian King
2007-08-17 14:16 ` [PATCH 3/6] ibmveth: Add ethtool TSO handlers Brian King
2007-08-17 14:16 ` Brian King
2007-08-31 13:14 ` Jeff Garzik [this message]
2007-08-31 13:14 ` Jeff Garzik
2007-08-17 14:16 ` [PATCH 4/6] ibmveth: Add ethtool driver stats hooks Brian King
2007-08-17 14:16 ` Brian King
2007-08-17 14:16 ` [PATCH 5/6] ibmveth: Remove dead frag processing code Brian King
2007-08-17 14:16 ` Brian King
2007-08-17 14:16 ` [PATCH 6/6] ibmveth: Remove use of bitfields Brian King
2007-08-17 14:16 ` Brian King
2007-08-31 13:32 ` [PATCH 1/6] ibmveth: Enable TCP checksum offload Jeff Garzik
2007-08-31 13:32 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-08-10 19:28 Brian King
2007-08-10 19:29 ` [PATCH 3/6] ibmveth: Add ethtool TSO handlers Brian King
2007-08-10 19:29 ` Brian King
2007-08-06 19:42 [PATCH 1/6] ibmveth: Enable TCP checksum offload Brian King
2007-08-06 19:42 ` [PATCH 3/6] ibmveth: Add ethtool TSO handlers Brian King
2007-08-06 19:42 ` Brian King
2007-08-07 21:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D8143C.9030603@garzik.org \
--to=jeff@garzik.org \
--cc=brking@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rcjenn@linux.vnet.ibm.com \
--cc=santil@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.