All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Linux Network Development list <netdev@vger.kernel.org>
Subject: Re: wither bounds checking for networking sysctls
Date: Fri, 31 Aug 2007 10:14:53 -0700	[thread overview]
Message-ID: <46D84C8D.4070009@hp.com> (raw)
In-Reply-To: <20070830205939.2f85a567@localhost>

Stephen Hemminger wrote:
> On Thu, 30 Aug 2007 18:09:17 -0700
> Rick Jones <rick.jones2@hp.com> wrote:
> 
> 
>>While messing about with "sysctl_tcp_rto_min" I went back and forth a 
>>bit as to whether there should have been bounds checking (as did some of 
>>the folks who did some internal review for me).  That leads to the 
>>question - is it considered worthwhile to add a bit more bounds checking 
>>to sundry networking sysctls?
>>
>>rick jones
> 
> 
> IMHO As long as the any value from sysctl doesn't crash kernel, we
> should let it go. Enforcing RFC policy or inter-dependencies seems
> likes a useless exercise.

I was thinking more along the lines of more fundamental things - like 
precluding negative values when something is clearly a positive.

rick jones

  reply	other threads:[~2007-08-31 17:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-31  1:09 wither bounds checking for networking sysctls Rick Jones
2007-08-31  3:59 ` Stephen Hemminger
2007-08-31 17:14   ` Rick Jones [this message]
2007-09-09 15:26     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D84C8D.4070009@hp.com \
    --to=rick.jones2@hp.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.