* Ath5k panic fix
@ 2007-09-03 18:35 Krzysztof Halasa
2007-09-03 18:55 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Halasa @ 2007-09-03 18:35 UTC (permalink / raw)
To: Jiri Slaby; +Cc: John W. Linville, Andrew Morton, linux-kernel, netdev
Ath5k panics on ath_open() because sc->pdev is never set, fixed.
Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
--- a/drivers/net/wireless/ath5k_base.c
+++ b/drivers/net/wireless/ath5k_base.c
@@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
hw->max_rssi = 127; /* FIXME: get a real value for this. */
sc = hw->priv;
sc->hw = hw;
+ sc->pdev = pdev;
/*
* Mark the device as detached to avoid processing
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Ath5k panic fix
2007-09-03 18:35 Ath5k panic fix Krzysztof Halasa
@ 2007-09-03 18:55 ` Jiri Slaby
2007-09-03 20:53 ` Nick Kossifidis
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2007-09-03 18:55 UTC (permalink / raw)
To: Krzysztof Halasa
Cc: Jiri Slaby, John W. Linville, Andrew Morton, linux-wireless
Krzysztof Halasa napsal(a):
> Ath5k panics on ath_open() because sc->pdev is never set, fixed.
>
> Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
I wonder how it is possible that the driver works here.
> --- a/drivers/net/wireless/ath5k_base.c
> +++ b/drivers/net/wireless/ath5k_base.c
> @@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
> hw->max_rssi = 127; /* FIXME: get a real value for this. */
> sc = hw->priv;
> sc->hw = hw;
> + sc->pdev = pdev;
>
> /*
> * Mark the device as detached to avoid processing
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Ath5k panic fix
2007-09-03 18:55 ` Jiri Slaby
@ 2007-09-03 20:53 ` Nick Kossifidis
0 siblings, 0 replies; 3+ messages in thread
From: Nick Kossifidis @ 2007-09-03 20:53 UTC (permalink / raw)
To: Jiri Slaby
Cc: Krzysztof Halasa, John W. Linville, Andrew Morton, linux-wireless
2007/9/3, Jiri Slaby <jirislaby@gmail.com>:
> Krzysztof Halasa napsal(a):
> > Ath5k panics on ath_open() because sc->pdev is never set, fixed.
> >
> > Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
>
> Acked-by: Jiri Slaby <jirislaby@gmail.com>
>
> I wonder how it is possible that the driver works here.
>
> > --- a/drivers/net/wireless/ath5k_base.c
> > +++ b/drivers/net/wireless/ath5k_base.c
> > @@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
> > hw->max_rssi = 127; /* FIXME: get a real value for this. */
> > sc = hw->priv;
> > sc->hw = hw;
> > + sc->pdev = pdev;
> >
> > /*
> > * Mark the device as detached to avoid processing
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
>
> thanks,
I've already fixed this on r2698 ;-)
http://madwifi.org/changeset/2698
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-03 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-03 18:35 Ath5k panic fix Krzysztof Halasa
2007-09-03 18:55 ` Jiri Slaby
2007-09-03 20:53 ` Nick Kossifidis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.