From: Rene Herman <rene.herman@gmail.com>
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: Alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] cs4231-lib: replace common delay loop by function
Date: Wed, 05 Sep 2007 21:11:09 +0200 [thread overview]
Message-ID: <46DEFF4D.1010903@gmail.com> (raw)
In-Reply-To: <20070905190911.34f41d66.krzysztof.h1@wp.pl>
On 09/05/2007 07:09 PM, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> This patch replaces a common delay loop by a function.
> It also uses ARRAY_SIZE macro for the rates table.
>
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> ---
> +static void snd_cs4231_wait(struct snd_cs4231 *chip)
> {
> int timeout;
> - unsigned char tmp;
>
> for (timeout = 250;
> timeout > 0 && (cs4231_inb(chip, CS4231P(REGSEL)) & CS4231_INIT);
> timeout--)
> udelay(100);
> +}
Like the inb() pulled out into the body of the for as you did for ad1848 a
bit better, but otherwise:
Acked-by: Rene Herman <rene.herman@gmail.com>
next prev parent reply other threads:[~2007-09-05 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 17:09 [PATCH] cs4231-lib: replace common delay loop by function Krzysztof Helt
2007-09-05 19:11 ` Rene Herman [this message]
[not found] <20070904184927.0bb3bc7c.krzysztof.h1@wp.pl>
2007-09-04 22:37 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DEFF4D.1010903@gmail.com \
--to=rene.herman@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=krzysztof.h1@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.