From: Randy Dunlap <randy.dunlap@oracle.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 8/8] Immediate Values - Documentation
Date: Fri, 07 Sep 2007 07:24:43 -0700 [thread overview]
Message-ID: <46E15F2B.3080607@oracle.com> (raw)
In-Reply-To: <20070907122353.GB9735@Krystal>
Mathieu Desnoyers wrote:
> * Randy Dunlap (randy.dunlap@oracle.com) wrote:
> [fixing the rest of the comments in the patch]
>> What character is this that I cannot read (not displayed properly
>> by my email client maybe)? <something> after 644.09 and before the
>> +- symbol, repeated just before all of the +- symbols.
>>
>
> This file seems to be UTF-8 and the mail has been send by quilt. Is it
> ok or should I change this to +/- just to make sure ?
I think that most people on lkml say that UTF-8 is OK in text doc files.
>>> +Getppid without memory pressure:
>>> +1462.09±18.87 - 150.92±1.01 = 1311.17±18.90 cycles
>>> +
>>> +Getppid with memory pressure:
>>> +17113.33±1655.92 - 578.22±269.51 = 16535.11±1677.71 cycles
>>> +
>>> +Therefore, if we add 2 markers not based on immediate values to the getppid
>>> +code, which would add 2 memory reads, we would add
>>> +2 * 555.93±12.74 = 1111.86±25.48 cycles
>>> +
>>> +Therefore,
>>> +
>>> +1111.86±25.48 / 16535.11±1677.71 = 0.0672
>>> + relative error: sqrt(((25.48/1111.86)^2)+((1677.71/16535.11)^2))
>>> + = 0.1040
>>> + absolute error: 0.1040 * 0.0672 = 0.0070
>>> +
>>> +Therefore: 0.0672±0.0070 * 100% = 6.72±0.70 %
>>> +
>>> +We can therefore affirm that adding 2 markers to getppid, on a system with high
>>> +memory pressure, would have a performance hit of at least 6.0% on the system
>>> +call time, all within the uncertainty limits of these tests. The same applies to
>>> +other kernel code paths. The smaller those code paths are, the highest the
>>> +impact ratio will be.
>>> +
>>> +Therefore, not only is it interesting to use the immediate values to dynamically
>>> +activate dormant code such as the markers, but I think it should also be
>>> +considered as a replacement for many of the "read mostly" static variables.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2007-09-07 14:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 20:02 [patch 0/8] Immediate Values for 2.6.23-rc4-mm1 Mathieu Desnoyers
2007-09-06 20:02 ` [patch 1/8] Immediate Values - Global Modules List and Module Mutex Mathieu Desnoyers
2007-09-08 7:28 ` Alexey Dobriyan
2007-09-10 23:53 ` Rusty Russell
2007-09-11 0:45 ` Mathieu Desnoyers
2007-09-11 5:18 ` Rusty Russell
2007-09-11 14:27 ` Mathieu Desnoyers
2007-09-13 5:47 ` Rusty Russell
2007-09-13 21:21 ` Mathieu Desnoyers
2007-09-13 23:15 ` Rusty Russell
2007-09-14 15:32 ` Mathieu Desnoyers
2007-09-17 22:54 ` Rusty Russell
2007-09-18 13:41 ` Mathieu Desnoyers
2007-09-20 12:29 ` Rusty Russell
2007-09-21 13:37 ` Mathieu Desnoyers
2007-09-22 7:15 ` Rusty Russell
2007-09-06 20:02 ` [patch 2/8] Immediate Values - Architecture Independent Code Mathieu Desnoyers
2007-09-06 20:02 ` [patch 3/8] Immediate Values - Kconfig menu in EMBEDDED Mathieu Desnoyers
2007-09-07 6:49 ` Andi Kleen
2007-09-07 12:46 ` Mathieu Desnoyers
2007-09-07 22:39 ` Andi Kleen
2007-09-11 20:22 ` Mathieu Desnoyers
2007-09-12 12:42 ` Andi Kleen
2007-09-06 20:02 ` [patch 4/8] Immediate Values - Move Kprobes i386 restore_interrupt to kdebug.h Mathieu Desnoyers
2007-09-07 10:31 ` Ananth N Mavinakayanahalli
2007-09-06 20:02 ` [patch 5/8] Immediate Values - i386 Optimization Mathieu Desnoyers
2007-09-06 20:02 ` [patch 6/8] Immediate Values - Powerpc Optimization Mathieu Desnoyers
2007-09-06 20:02 ` [patch 7/8] Immediate Values Powerpc Optimization Fix Mathieu Desnoyers
2007-09-06 20:02 ` [patch 8/8] Immediate Values - Documentation Mathieu Desnoyers
2007-09-06 21:20 ` Randy Dunlap
2007-09-07 12:23 ` Mathieu Desnoyers
2007-09-07 14:24 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E15F2B.3080607@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.