All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Krzysztof Helt <krzysztof.h1@gmail.com>,
	ALSA devel <alsa-devel@alsa-project.org>
Subject: [PATCH] ad1848: fix AD1848P macro
Date: Sun, 09 Sep 2007 19:35:27 +0200	[thread overview]
Message-ID: <46E42EDF.3090508@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

Hi.

Consistent variable naming is a good thing, but let's be a little less 
sneaky about enforcing it... ;-/

Rene.

[-- Attachment #2: ad1848_eeks.diff --]
[-- Type: text/plain, Size: 378 bytes --]

diff --git a/include/sound/ad1848.h b/include/sound/ad1848.h
index b2c3f00..ca0b6c3 100644
--- a/include/sound/ad1848.h
+++ b/include/sound/ad1848.h
@@ -27,7 +27,7 @@
 
 /* IO ports */
 
-#define AD1848P( codec, x ) ( (chip) -> port + c_d_c_AD1848##x )
+#define AD1848P( chip, x ) ( (chip) -> port + c_d_c_AD1848##x )
 
 #define c_d_c_AD1848REGSEL	0
 #define c_d_c_AD1848REG		1

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

             reply	other threads:[~2007-09-09 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-09 17:35 Rene Herman [this message]
2007-09-09 17:42 ` [PATCH] ad1848: fix AD1848P macro Rene Herman
2007-09-10 21:16   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E42EDF.3090508@gmail.com \
    --to=rene.herman@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=krzysztof.h1@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.