[PATCH] ad1848: fix AD1848P macro

[PATCH] ad1848: fix AD1848P macro

[Rene Herman]

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

Hi.

Consistent variable naming is a good thing, but let's be a little less 
sneaky about enforcing it... ;-/

Rene.

[-- Attachment #2: ad1848_eeks.diff --]
[-- Type: text/plain, Size: 378 bytes --]

diff --git a/include/sound/ad1848.h b/include/sound/ad1848.h
index b2c3f00..ca0b6c3 100644
--- a/include/sound/ad1848.h
+++ b/include/sound/ad1848.h
@@ -27,7 +27,7 @@
 
 /* IO ports */
 
-#define AD1848P( codec, x ) ( (chip) -> port + c_d_c_AD1848##x )
+#define AD1848P( chip, x ) ( (chip) -> port + c_d_c_AD1848##x )
 
 #define c_d_c_AD1848REGSEL	0
 #define c_d_c_AD1848REG		1

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ad1848: fix AD1848P macro

[Rene Herman]

On 09/09/2007 07:35 PM, Rene Herman wrote:

> Consistent variable naming is a good thing, but let's be a little less 
> sneaky about enforcing it... ;-/

Signed-off-by: Rene Herman <rene.herman@gmail.com>

Rene.

Re: [PATCH] ad1848: fix AD1848P macro

[Takashi Iwai]

At Sun, 09 Sep 2007 19:42:56 +0200,
Rene Herman wrote:
> 
> On 09/09/2007 07:35 PM, Rene Herman wrote:
> 
> > Consistent variable naming is a good thing, but let's be a little less 
> > sneaky about enforcing it... ;-/
> 
> Signed-off-by: Rene Herman <rene.herman@gmail.com>

Applied.  Thanks.


Takashi