* [PATCH] ad1848: fix AD1848P macro
@ 2007-09-09 17:35 Rene Herman
2007-09-09 17:42 ` Rene Herman
0 siblings, 1 reply; 3+ messages in thread
From: Rene Herman @ 2007-09-09 17:35 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Krzysztof Helt, ALSA devel
[-- Attachment #1: Type: text/plain, Size: 117 bytes --]
Hi.
Consistent variable naming is a good thing, but let's be a little less
sneaky about enforcing it... ;-/
Rene.
[-- Attachment #2: ad1848_eeks.diff --]
[-- Type: text/plain, Size: 378 bytes --]
diff --git a/include/sound/ad1848.h b/include/sound/ad1848.h
index b2c3f00..ca0b6c3 100644
--- a/include/sound/ad1848.h
+++ b/include/sound/ad1848.h
@@ -27,7 +27,7 @@
/* IO ports */
-#define AD1848P( codec, x ) ( (chip) -> port + c_d_c_AD1848##x )
+#define AD1848P( chip, x ) ( (chip) -> port + c_d_c_AD1848##x )
#define c_d_c_AD1848REGSEL 0
#define c_d_c_AD1848REG 1
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ad1848: fix AD1848P macro
2007-09-09 17:35 [PATCH] ad1848: fix AD1848P macro Rene Herman
@ 2007-09-09 17:42 ` Rene Herman
2007-09-10 21:16 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Rene Herman @ 2007-09-09 17:42 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Krzysztof Helt, ALSA devel
On 09/09/2007 07:35 PM, Rene Herman wrote:
> Consistent variable naming is a good thing, but let's be a little less
> sneaky about enforcing it... ;-/
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Rene.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ad1848: fix AD1848P macro
2007-09-09 17:42 ` Rene Herman
@ 2007-09-10 21:16 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2007-09-10 21:16 UTC (permalink / raw)
To: Rene Herman; +Cc: Krzysztof Helt, ALSA devel
At Sun, 09 Sep 2007 19:42:56 +0200,
Rene Herman wrote:
>
> On 09/09/2007 07:35 PM, Rene Herman wrote:
>
> > Consistent variable naming is a good thing, but let's be a little less
> > sneaky about enforcing it... ;-/
>
> Signed-off-by: Rene Herman <rene.herman@gmail.com>
Applied. Thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-10 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-09 17:35 [PATCH] ad1848: fix AD1848P macro Rene Herman
2007-09-09 17:42 ` Rene Herman
2007-09-10 21:16 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.