Re: [PATCH] ad1838/cs4231 -- fix MCE timeout upon initial load

[Rene Herman <rene.herman@gmail.com>]

On 09/10/2007 11:40 PM, Krzysztof Helt wrote:

> On Mon, 10 Sep 2007 20:29:21 +0200
> Rene Herman <rene.herman@gmail.com> wrote:
>> Thanks to Krysztof Helt for pinpointing this problem.
>>
> 
> Please change it to Krzysztof Helt

Oh, very sorry.

>> diff --git a/sound/isa/cs423x/cs4231_lib.c b/sound/isa/cs423x/cs4231_lib.c
>> index 914d77b..9e8e0f1 100644
>> --- a/sound/isa/cs423x/cs4231_lib.c
>> +++ b/sound/isa/cs423x/cs4231_lib.c
>> @@ -346,16 +346,14 @@ void snd_cs4231_mce_down(struct snd_cs4231 *chip)
>>  	}
>>  	snd_cs4231_busy_wait(chip);
>>  
>> -	/* calibration process */
>> -
> 
> The snd_cs4231_busy_wait(chip) is not needed any more here.

I believe it is. I glanced over the CS4232 datasheet (note how cs4232 uses 
snd-cs4332-lib) and it adds a point 4 (see page 53):

* Wait until 80h NOT returned

I didn't read closely, so feel free to point out if I'm misinterpreting that.

Rene.