[PATCH 2/4] alsa-kernel: schedule_timeout() fix for kernel/drivers/input/touchscreen/ucb1400_ts.c

[Rene Herman <rene.herman@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

On 09/18/2007 01:54 PM, Takashi Iwai wrote:

> The other changes look good to me.  But, honestly, I couldn't follow all
> the pathes you sent in the right order.  So, could you guys make a series
> of patches to be applied to HG tree?  That'll be really helpful for
> review, too.

Only split of from the rest since I'm not in fact sure what/why that 
drivers/input stuff is inside alsa-kernel.

===

alsa-kernel: schedule_timeout() fix for ucb1400_ts.c

ucb14ts_ts.c is doing a (manual) schedule_timeout_uninterruptible, but is 
not actually checking for pending signals. An _uninterruptible() one will do 
then.

Signed-off-by: Rene Herman <rene.herman>

[-- Attachment #2: schedule_timeout-ucb1400_ts.diff --]
[-- Type: text/plain, Size: 516 bytes --]

diff -r 0028e39ead78 kernel/drivers/input/touchscreen/ucb1400_ts.c
--- a/kernel/drivers/input/touchscreen/ucb1400_ts.c	Tue Sep 18 00:52:38 2007 +0200
+++ b/kernel/drivers/input/touchscreen/ucb1400_ts.c	Tue Sep 18 14:51:04 2007 +0200
@@ -130,8 +130,7 @@ static unsigned int ucb1400_adc_read(str
 		if (val & UCB_ADC_DAT_VALID)
 			break;
 		/* yield to other processes */
-		set_current_state(TASK_INTERRUPTIBLE);
-		schedule_timeout(1);
+		schedule_timeout_uninterruptible(1);
 	}
 
 	return UCB_ADC_DAT_VALUE(val);

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel