All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Zhang Wei-r63237 <Wei.Zhang@freescale.com>
Cc: shannon.nelson@intel.com, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, paulus@samba.org,
	dan.j.williams@intel.com
Subject: Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.
Date: Tue, 11 Sep 2007 07:20:09 -0700	[thread overview]
Message-ID: <46E6A419.9070101@oracle.com> (raw)
In-Reply-To: <46B96294322F7D458F9648B60E15112C85D61C@zch01exm26.fsl.freescale.net>

Zhang Wei-r63237 wrote:

>>> +/**
>>> + * fsl_chan_xfer_ld_queue -- Transfer the link descriptors 
>> in channel
>>> + *                           ld_queue.
>> The function's "short description" (unfortunately) must be on only one
>> line.  E.g.:
>>
>>  * fsl_chan_xfer_ld_queue - Transfer link descriptors in 
>> channel ld_queue.
>>
> 
> How about it's length greater than 80?

If it's close to 80+, you can just leave it like that.
If it's much longer, you can use this format:

/**
 * function_name - short description
 * @parameters: prm description
 *
 * Longer
 *      function
 *             description.
 */



Thanks,
~Randy

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Zhang Wei-r63237 <Wei.Zhang@freescale.com>
Cc: paulus@samba.org, shannon.nelson@intel.com,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	galak@kernel.crashing.org,
	Zhu Ebony-r57400 <ebony.zhu@freescale.com>,
	dan.j.williams@intel.com
Subject: Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.
Date: Tue, 11 Sep 2007 07:20:09 -0700	[thread overview]
Message-ID: <46E6A419.9070101@oracle.com> (raw)
In-Reply-To: <46B96294322F7D458F9648B60E15112C85D61C@zch01exm26.fsl.freescale.net>

Zhang Wei-r63237 wrote:

>>> +/**
>>> + * fsl_chan_xfer_ld_queue -- Transfer the link descriptors 
>> in channel
>>> + *                           ld_queue.
>> The function's "short description" (unfortunately) must be on only one
>> line.  E.g.:
>>
>>  * fsl_chan_xfer_ld_queue - Transfer link descriptors in 
>> channel ld_queue.
>>
> 
> How about it's length greater than 80?

If it's close to 80+, you can just leave it like that.
If it's much longer, you can use this format:

/**
 * function_name - short description
 * @parameters: prm description
 *
 * Longer
 *      function
 *             description.
 */



Thanks,
~Randy

  reply	other threads:[~2007-09-11 14:21 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-07 10:54 [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors Zhang Wei
2007-09-07 10:54 ` Zhang Wei
2007-09-07 15:58 ` Randy Dunlap
2007-09-07 15:58   ` Randy Dunlap
2007-09-11 10:06   ` Zhang Wei-r63237
2007-09-11 10:06     ` Zhang Wei-r63237
2007-09-11 14:20     ` Randy Dunlap [this message]
2007-09-11 14:20       ` Randy Dunlap
2007-09-07 16:00 ` Nelson, Shannon
2007-09-07 16:00   ` Nelson, Shannon
2007-09-11 10:10   ` Zhang Wei-r63237
2007-09-11 10:10     ` Zhang Wei-r63237
2007-09-11 14:20     ` Scott Wood
2007-09-11 14:20       ` Scott Wood
2007-09-11 15:15       ` Nelson, Shannon
2007-09-11 15:15         ` Nelson, Shannon
2007-09-09 17:53 ` Dan Williams
2007-09-09 17:53   ` Dan Williams
2007-09-09 21:48   ` Timur Tabi
2007-09-09 21:48     ` Timur Tabi
2007-09-09 22:10     ` Dan Williams
2007-09-09 22:10       ` Dan Williams
2007-09-11 10:30   ` Zhang Wei-r63237
2007-09-11 10:30     ` Zhang Wei-r63237
2007-09-13 17:17     ` Dan Williams
2007-09-13 17:17       ` Dan Williams
     [not found] ` <20070907223553.GA18599@freescale.com>
2007-09-13 10:13   ` [PATCH 5/5] Add DMA engine driver for Freescale MPC85xxprocessors Zhang Wei-r63237
2007-09-13 10:13     ` Zhang Wei-r63237
2007-09-13 14:49     ` Scott Wood
2007-09-13 14:49       ` Scott Wood
2007-09-13 16:25     ` Dan Williams
2007-09-13 16:25       ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E6A419.9070101@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=Wei.Zhang@freescale.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.