All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Michael Neuling <mikey@neuling.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	paulus@samba.org, Alan Cox <alan@redhat.com>,
	akpm@linux-foundation.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] powerpc: add new required termio functions
Date: Tue, 11 Sep 2007 19:19:01 -0700	[thread overview]
Message-ID: <46E74C95.3090402@am.sony.com> (raw)
In-Reply-To: <8018.1189562679@neuling.org>

Michael Neuling wrote:
> The "tty: termios locking functions break with new termios type" patch
> (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile.
> This adds the required API to asm-powerpc.
> 
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> --
> This needs to go up for 2.6.23.
> 
> Should we really put these definitions in asm-generic/termios.h as I'm
> guessing other architectures are broken too?

I think it would be better to do so, as that is where we pickup the defs for
the original kernel_termios_to_user_termios and user_termios_to_kernel_termios.

-Geoff

WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Michael Neuling <mikey@neuling.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	akpm@linux-foundation.org, paulus@samba.org,
	Alan Cox <alan@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: add new required termio functions
Date: Tue, 11 Sep 2007 19:19:01 -0700	[thread overview]
Message-ID: <46E74C95.3090402@am.sony.com> (raw)
In-Reply-To: <8018.1189562679@neuling.org>

Michael Neuling wrote:
> The "tty: termios locking functions break with new termios type" patch
> (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile.
> This adds the required API to asm-powerpc.
> 
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> --
> This needs to go up for 2.6.23.
> 
> Should we really put these definitions in asm-generic/termios.h as I'm
> guessing other architectures are broken too?

I think it would be better to do so, as that is where we pickup the defs for
the original kernel_termios_to_user_termios and user_termios_to_kernel_termios.

-Geoff

  parent reply	other threads:[~2007-09-12  2:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12  2:04 [PATCH] powerpc: add new required termio functions Michael Neuling
2007-09-12  2:04 ` Michael Neuling
2007-09-12  2:17 ` Linus Torvalds
2007-09-12  2:17   ` Linus Torvalds
2007-09-12  2:33   ` Tony Breeds
2007-09-12  2:34   ` Michael Neuling
2007-09-12  2:34     ` Michael Neuling
2007-09-12  2:19 ` Geoff Levand [this message]
2007-09-12  2:19   ` Geoff Levand
2007-09-12 10:20 ` Heiko Carstens
2007-09-12 10:20   ` Heiko Carstens
2007-09-12 11:01   ` Andrew Morton
2007-09-12 11:01     ` Andrew Morton
2007-09-12 11:16     ` Michael Neuling
2007-09-12 11:16       ` Michael Neuling
2007-09-12 11:34     ` Christoph Hellwig
2007-09-12 11:34       ` Christoph Hellwig
2007-09-12 11:52       ` Heiko Carstens
2007-09-12 13:49         ` Christoph Hellwig
2007-09-12 13:49           ` Christoph Hellwig
2007-09-14 14:20           ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E74C95.3090402@am.sony.com \
    --to=geoffrey.levand@am.sony.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.