Re: sk98lin for 2.6.23-rc1

Re: sk98lin for 2.6.23-rc1

[Daniel J Blueman]

> If anyone still has hang issues with sky2, please send me the hardware
> information (lspci, dmesg output), and capture the debugfs state after hang.
>
> At present the known open skge, sky2 issues are:
[snip]

There is still this active issue which I believe is orthogonal from
the interrupt hang. I just hit it again. The IRQ-hang recovery logic
doesn't seem to kick in, so it's perhaps another issue:

# ifconfig lan0
lan0      Link encap:Ethernet  HWaddr 00:03:2D:05:9C:27
          inet addr:192.168.0.250  Bcast:192.168.0.255  Mask:255.255.255.0
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:13304841 errors:1 dropped:1 overruns:0 frame:2
          TX packets:7493765 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:232720755 (221.9 MiB)  TX bytes:3964088142 (3.6 GiB)
          Interrupt:16

# ethtool -S lan0
NIC statistics:
     tx_bytes: 44342166229
     rx_bytes: 28807483162
     tx_broadcast: 20071
     rx_broadcast: 3309
     tx_multicast: 0
     rx_multicast: 31
     tx_unicast: 45095221
     rx_unicast: 43331790
     tx_mac_pause: 0
     rx_mac_pause: 278
     collisions: 0
     late_collision: 0
     aborted: 0
     single_collisions: 0
     multi_collisions: 0
     rx_short: 0
     rx_runt: 0
     rx_64_byte_packets: 1815009
     rx_65_to_127_byte_packets: 18626585
     rx_128_to_255_byte_packets: 788459
     rx_256_to_511_byte_packets: 4880174
     rx_512_to_1023_byte_packets: 1016831
     rx_1024_to_1518_byte_packets: 16208350
     rx_1518_to_max_byte_packets: 0
     rx_too_long: 0
     rx_fifo_overflow: 0
     rx_jabber: 0
     rx_fcs_error: 0
     tx_64_byte_packets: 1632797
     tx_65_to_127_byte_packets: 11211285
     tx_128_to_255_byte_packets: 1628446
     tx_256_to_511_byte_packets: 2042646
     tx_512_to_1023_byte_packets: 637342
     tx_1024_to_1518_byte_packets: 27962776
     tx_1519_to_max_byte_packets: 0
     tx_fifo_underrun: 0

# dmesg
[snip]
sky2 0000:01:00.0: v1.16 addr 0xdfbfc000 irq 16 Yukon-EC (0xb6) rev 1
sky2 eth1: addr 00:03:2d:05:9c:27
sky2 lan0: enabling interface
sky2 lan0: ram buffer 48K
[snip]
sky2 lan0: rx error, status 0xad78ad78 length 0
lan0: hw csum failure.
[stack-trace snipped]
lan0: hw csum failure.
...

# cat /debug/sky2/lan0
IRQ src=0 mask=c000001d control=0
Status ring (empty)
Tx ring pending=424...424 report=424 done=424

Rx ring hw get=252 put=405 last=1023

# cat /debug/sky2/lan0
IRQ src=0 mask=c000001d control=0
Status ring (empty)
Tx ring pending=432...432 report=432 done=432

Rx ring hw get=252 put=415 last=1023

# cat /debug/sky2/lan0
IRQ src=0 mask=c000001d control=0
Status ring (empty)
Tx ring pending=451...451 report=451 done=451

Rx ring hw get=316 put=440 last=1023
-- 
Daniel J Blueman

[PATCH 2/3] sk98lin: ethtool perm_addr build fix

[Stephen Hemminger]

Deal with API changes while sk98lin was removed.
ethtool_ops no longer has a perm_addr hook.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
 drivers/net/sk98lin/skethtool.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/sk98lin/skethtool.c b/drivers/net/sk98lin/skethtool.c
index 3646069..5a6da89 100644
--- a/drivers/net/sk98lin/skethtool.c
+++ b/drivers/net/sk98lin/skethtool.c
@@ -616,7 +616,6 @@ const struct ethtool_ops SkGeEthtoolOps = {
 	.get_pauseparam		= getPauseParams,
 	.set_pauseparam		= setPauseParams,
 	.get_link		= ethtool_op_get_link,
-	.get_perm_addr		= ethtool_op_get_perm_addr,
 	.get_sg			= ethtool_op_get_sg,
 	.set_sg			= setScatterGather,
 	.get_tx_csum		= ethtool_op_get_tx_csum,
-- 
1.5.2.5

[PATCH 3/3]: sk98lin: neuter device to only SysKonnect boards

[Stephen Hemminger]

The skge driver works better for all boards except older SysKonnect
boards.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
 drivers/net/sk98lin/skge.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c
index bf21862..7dc9c9e 100644
--- a/drivers/net/sk98lin/skge.c
+++ b/drivers/net/sk98lin/skge.c
@@ -5168,10 +5168,17 @@ err_out:
 #endif
 
 static struct pci_device_id skge_pci_tbl[] = {
+#ifdef SK98LIN_ALL_DEVICES
 	{ PCI_VENDOR_ID_3COM, 0x1700, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
 	{ PCI_VENDOR_ID_3COM, 0x80eb, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+#endif
+#ifdef GENESIS
+	/* Generic SysKonnect SK-98xx Gigabit Ethernet Server Adapter */	
 	{ PCI_VENDOR_ID_SYSKONNECT, 0x4300, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+#endif
+	/* Generic SysKonnect SK-98xx V2.0 Gigabit Ethernet Adapter */	
 	{ PCI_VENDOR_ID_SYSKONNECT, 0x4320, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+#ifdef SK98LIN_ALL_DEVICES
 /* DLink card does not have valid VPD so this driver gags
  *	{ PCI_VENDOR_ID_DLINK, 0x4c00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
  */
@@ -5180,6 +5187,7 @@ static struct pci_device_id skge_pci_tbl[] = {
 	{ PCI_VENDOR_ID_CNET, 0x434e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
 	{ PCI_VENDOR_ID_LINKSYS, 0x1032, PCI_ANY_ID, 0x0015, },
 	{ PCI_VENDOR_ID_LINKSYS, 0x1064, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+#endif
 	{ 0 }
 };
 
-- 
1.5.2.5

Re: [PATCH 3/3]: sk98lin: neuter device to only SysKonnect boards

[Jeff Garzik]

applied 1-3 as a single commit, so that git-bisect will not break

	Jeff

[PATCH 1/3] sk98lin: restore driver

[Stephen Hemminger]

This reverts commit e1abecc48938fbe1966ea6e78267fc673fa59295.

The driver works on some hardware that skge doesn't handle yet.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

-----------
Patch too large for mailing list. Download from:
	http://developer.osdl.org/shemminger/patches/sk98lin-2.6.23-restore.patch