Re: [PATCH] cs4231: remove two auto-calibrations during chip initialization

[Rene Herman <rene.herman@gmail.com>]

On 09/18/2007 01:08 PM, Jaroslav Kysela wrote:

> On Tue, 18 Sep 2007, Rene Herman wrote:
> 
>> On 09/18/2007 12:17 PM, Krzysztof Helt wrote:
>>
>>> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>>>
>>> The initialization function did auto-calibration after each
>>> register setting. This patch merges more register changes
>>> before auto-calibration is done.
>> Seems to make sense but am a little uneasy about these -- someone very much
>> did it this way on purpose originally it seems. Jaroslav, that someone was you
>> I believe? Do you remember anything about this?
> 
> If I remember correctly, it was workaround for some CS4231 chips to fix 
> the noise audio issue (the chip was not initialized correctly in some 
> cases). I would make a whitelist for "non-buggy" tested chips to skip 
> double calibration.

Okay thanks. For reference, I have:

AD1848
AD1848KP
AD1845JP
AD1845XP
AD1846JP

CS4248-KL
CS4231
CS4231A-KL
CS4232-KQ
CS4235-XQ3
CS4236B-KQ
CS4237B-XQ3
CS4239-KQ

(Won't be testing right now, but will be generally available).

Rene.