Re: 2.6.23-rc6-mm1

[Gabriel C <nix.or.die@googlemail.com>]

Gabriel C wrote:
> Sam Ravnborg wrote:
>> On Tue, Sep 18, 2007 at 03:42:58PM -0400, Miles Lane wrote:
>>> On 9/18/07, Sam Ravnborg <sam@ravnborg.org> wrote:
>>>> Hi Miles.
>>>> On Tue, Sep 18, 2007 at 11:27:23AM -0400, Miles Lane wrote:
>>>>> Selecting Help for "Subarchitecture Type" causes "make menuconfig" to
>>>>> crash, and the bash display settings have to be reset.
>>>> Not reproduceable here.
>>>> But I noticed that we pass a null pointer to a vsprintf function which
>>>> in the cases you pointed out printed a (null) at my system.
>>>> Could you plase try if attached patch fix your system.
>>> Sorry, it still crashes.  I am running Ubuntu pre-6.10 (Gutsy -- the
>>> development version of the distro).  Maybe I should try "make
>>> mrproper" first?
>> make mrproper should not do any difference here.
>> I rather think you hit some ncurses bug.
>>
>> If you could add '-g' to HOSTCFLAGS in top-level Makefile
>> and then do:
>> rm scripts/kconfig/mconf.o scripts/kconfig/mconf
>> make menuconfig
>>
>> (to build mconf and to check that the error is still reproduceable).
>> And then run it in a debugger like this:
>> gdb scripts/kconfig/mconf
>> run arch/x86_64/Kconfig
>>          ^^^^^^ replace with your actual arch
>>
>> Provoke the error and get a back-trace with 'bt'.
> 
> Hi Sam,
> 
> I can reproduce this bug on Frugalware Linux. 
> 
> Here the bt:
> 
> Program received signal SIGSEGV, Segmentation fault.                                                     
> 0xb7dc4143 in strlen () from /lib/libc.so.6                                                                                                                                       
> (gdb) bt                                                                                                                                                                          
> #0  0xb7dc4143 in strlen () from /lib/libc.so.6                                                                                                                                   
> #1  0x0804fd60 in str_append (gs=0xbfe4f6e8, s=0x0) at scripts/kconfig/util.c:87                                                                                                  
> #2  0x0804e0cb in expr_print (e=0x8e22df8, fn=0x804fda0 <expr_print_gstr_helper>, data=0xbfe4f6e8, prevtoken=0) at scripts/kconfig/expr.c:1037                                    
> #3  0x0804e1e7 in expr_gstr_print (e=0x8e22df8, gs=0xbfe4f6e8) at scripts/kconfig/expr.c:1099                                                                                     
> #4  0x0804a07e in get_symbol_str (r=0xbfe4f6e8, sym=0x8b54ee8) at scripts/kconfig/mconf.c:334                                                                                     
> #5  0x0804a363 in show_help (menu=0x8b54f88) at scripts/kconfig/mconf.c:738                                                                                                       
> #6  0x0804acec in conf (menu=0x8b69480) at scripts/kconfig/mconf.c:781                                                                                                            
> #7  0x0804a971 in conf (menu=0x8063c40) at scripts/kconfig/mconf.c:703                                                                                                            
> #8  0x0804af8a in main (ac=Cannot access memory at address 0x0                                                                                                                    
> ) at scripts/kconfig/mconf.c:917
> 
> 
> Looks somewhat strange -> http://194.231.229.228/menuconfig.png
> 
> PS: Is without the patch you posted , I'll try with in a bit

The crash is still there but the (null)'s are all fixed by this patch.
 
Gabriel