All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] XFS update for 2.6.23
@ 2007-09-18 11:24 Tim Shimmin
  2007-09-19 17:50 ` Eric Sandeen
  0 siblings, 1 reply; 4+ messages in thread
From: Tim Shimmin @ 2007-09-18 11:24 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, xfs, akpm

Hi Linus,

A couple of fixes for potential fs corruption.
And one fix to ensure that xfs_mru_cache is not
doing anything unless the cache has active objects.


Please pull from the for-linus branch:
    git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus

This will update the following files:

 fs/xfs/linux-2.6/xfs_aops.c  |    1 +
 fs/xfs/linux-2.6/xfs_super.c |    4 ++-
 fs/xfs/xfs_buf_item.h        |    5 +++
 fs/xfs/xfs_filestream.c      |    3 +-
 fs/xfs/xfs_log_recover.c     |   51 ++++++++++++++++++++++++++++--
 fs/xfs/xfs_mru_cache.c       |   72 ++++++++++++++++-------------------------
 fs/xfs/xfs_mru_cache.h       |    6 +--
 fs/xfs/xfs_trans_buf.c       |    1 +
 fs/xfs/xfs_vnodeops.c        |   20 +++++++-----
 9 files changed, 101 insertions(+), 62 deletions(-)

through these commits:

commit b394e43e995d08821588a22561c6a71a63b4ff27
Author: Lachlan McIlroy <lachlan@sgi.com>
Date:   Fri Sep 14 15:23:04 2007 +1000

    [XFS] Avoid replaying inode buffer initialisation log items if on-disk version is newer.
    
    SGI-PV: 969656
    SGI-Modid: xfs-linux-melb:xfs-kern:29676a
    
    Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
    Signed-off-by: David Chinner <dgc@sgi.com>
    Signed-off-by: Tim Shimmin <tes@sgi.com>

commit 776a75fa5cfb8f3602d3ca9d221dc34497133f4b
Author: Lachlan McIlroy <lachlan@sgi.com>
Date:   Fri Sep 14 15:22:50 2007 +1000

    [XFS] Ensure file size updates have been completed before writing inode to disk.
    
    SGI-PV: 968767
    SGI-Modid: xfs-linux-melb:xfs-kern:29675a
    
    Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
    Signed-off-by: David Chinner <dgc@sgi.com>
    Signed-off-by: Tim Shimmin <tes@sgi.com>

commit 65de5567564e70edd01b6d4e95e548d7ba284872
Author: David Chinner <dgc@sgi.com>
Date:   Thu Aug 16 15:21:11 2007 +1000

    [XFS] On-demand reaping of the MRU cache
    
    Instead of running the mru cache reaper all the time based on a timeout,
    we should only run it when the cache has active objects. This allows CPUs
    to sleep when there is no activity rather than be woken repeatedly just to
    check if there is anything to do.
    
    SGI-PV: 968554
    SGI-Modid: xfs-linux-melb:xfs-kern:29305a
    
    Signed-off-by: David Chinner <dgc@sgi.com>
    Signed-off-by: Donald Douwsma <donaldd@sgi.com>
    Signed-off-by: Tim Shimmin <tes@sgi.com>

--Tim

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [GIT PULL] XFS update for 2.6.23
@ 2007-09-20 10:12 Tim Shimmin
  0 siblings, 0 replies; 4+ messages in thread
From: Tim Shimmin @ 2007-09-20 10:12 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, xfs, akpm

Hi Linus,

A couple of small fixes.
One for harmless sparse warnings and one which can prevent
crashes on 32 bit boxes using filestreams.

Please pull from the for-linus branch:
    git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus

This will update the following files:

 fs/xfs/xfs_filestream.c  |    7 ++++---
 fs/xfs/xfs_log_recover.c |    4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

through these commits:

commit 1bc5858d0d40e07697b5eda47ed8628b8a934235
Author: Christoph Hellwig <hch@infradead.org>
Date:   Wed Sep 19 15:27:30 2007 +1000

    [XFS] fix valid but harmless sparse warning
    
    The new xlog_recover_do_reg_buffer checks call be16_to_cpu on di_gen which
    is a 32bit value so sparse rightly complains. Fortunately the warning is
    harmless because we don't care for the value, but only whether it's
    non-NULL. Due to that fact we can simply kill the endian swaps on this and
    the previous di_mode check entirely.
    
    SGI-PV: 969656
    SGI-Modid: xfs-linux-melb:xfs-kern:29709a
    
    Signed-off-by: Christoph Hellwig <hch@infradead.org>
    Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
    Signed-off-by: Tim Shimmin <tes@sgi.com>

commit bcc7b445eff295664a3a3ab14e742b3c9d88e6e3
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Thu Aug 30 17:21:38 2007 +1000

    [XFS] fix filestreams on 32-bit boxes
    
    xfs_filestream_mount() sets up an mru cache with:
      err = xfs_mru_cache_create(&mp->m_filestream, lifetime, grp_count,
      (xfs_mru_cache_free_func_t)xfs_fstrm_free_func);
    but that cast is causing problems...
      typedef void (*xfs_mru_cache_free_func_t)(unsigned long, void*);
    but:
      void xfs_fstrm_free_func( xfs_ino_t ino, fstrm_item_t *item)
    so on a 32-bit box, it's casting (32, 32) args into (64, 32) and I assume
    it's getting garbage for *item, which subsequently causes an explosion.
    With this change the filestreams xfsqa tests don't oops on my 32-bit box.
    
    SGI-PV: 967795
    SGI-Modid: xfs-linux-melb:xfs-kern:29510a
    
    Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
    Signed-off-by: David Chinner <dgc@sgi.com>
    Signed-off-by: Tim Shimmin <tes@sgi.com>

--Tim

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-09-20 10:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-18 11:24 [GIT PULL] XFS update for 2.6.23 Tim Shimmin
2007-09-19 17:50 ` Eric Sandeen
2007-09-20  7:35   ` Timothy Shimmin
  -- strict thread matches above, loose matches on Subject: below --
2007-09-20 10:12 Tim Shimmin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.