From: Jeff Garzik <jeff@garzik.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: David Miller <davem@davemloft.net>,
hch@infradead.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, flamingice@sourmilk.net
Subject: Re: Please pull 'p54' branch of wireless-2.6
Date: Wed, 19 Sep 2007 18:01:32 -0400 [thread overview]
Message-ID: <46F19C3C.6090605@garzik.org> (raw)
In-Reply-To: <20070919212607.GA3036@tuxdriver.com>
John W. Linville wrote:
> On Wed, Sep 19, 2007 at 02:12:00PM -0700, David Miller wrote:
>> From: Christoph Hellwig <hch@infradead.org>
>> Date: Wed, 19 Sep 2007 22:04:05 +0100
>>
>>> PLease put it into a separate subdirectory, thanks.
>>>
>>> Also net2280.h seems rather oddly named.
>> The next time I rebase I'll try to take care of this for both
>> this driver and the iwlwifi stuff.
>
> Fine by me, although I swear I remember complaints about adding separate
> directories for drivers...*shrug*...
There were complaints about the nonsensical wireless/mac80211 directory.
But if there are enough files, a driver should definitely get its own
directory. Like life, it's a balance. If it's just one or two C files,
a directory might be overkill. If it's more, it definitely warrants a
sub-dir.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
To: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
flamingice-R9e9/4HEdknk1uMJSBkQmQ@public.gmane.org
Subject: Re: Please pull 'p54' branch of wireless-2.6
Date: Wed, 19 Sep 2007 18:01:32 -0400 [thread overview]
Message-ID: <46F19C3C.6090605@garzik.org> (raw)
In-Reply-To: <20070919212607.GA3036-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
John W. Linville wrote:
> On Wed, Sep 19, 2007 at 02:12:00PM -0700, David Miller wrote:
>> From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
>> Date: Wed, 19 Sep 2007 22:04:05 +0100
>>
>>> PLease put it into a separate subdirectory, thanks.
>>>
>>> Also net2280.h seems rather oddly named.
>> The next time I rebase I'll try to take care of this for both
>> this driver and the iwlwifi stuff.
>
> Fine by me, although I swear I remember complaints about adding separate
> directories for drivers...*shrug*...
There were complaints about the nonsensical wireless/mac80211 directory.
But if there are enough files, a driver should definitely get its own
directory. Like life, it's a balance. If it's just one or two C files,
a directory might be overkill. If it's more, it definitely warrants a
sub-dir.
Jeff
next prev parent reply other threads:[~2007-09-19 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 19:55 Please pull 'p54' branch of wireless-2.6 John W. Linville
2007-09-19 20:20 ` David Miller
2007-09-19 21:04 ` Christoph Hellwig
2007-09-19 21:04 ` Christoph Hellwig
2007-09-19 21:12 ` David Miller
2007-09-19 21:26 ` John W. Linville
2007-09-19 21:26 ` John W. Linville
2007-09-19 22:01 ` Jeff Garzik [this message]
2007-09-19 22:01 ` Jeff Garzik
2007-09-19 22:08 ` David Miller
2007-09-19 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F19C3C.6090605@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=flamingice@sourmilk.net \
--cc=hch@infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.