All of lore.kernel.org
 help / color / mirror / Atom feed
* Bug in cmdlinepart.c?
@ 2007-09-21  7:59 M8 (Servaes Joordens)
  0 siblings, 0 replies; only message in thread
From: M8 (Servaes Joordens) @ 2007-09-21  7:59 UTC (permalink / raw)
  To: linux-mtd

Dear sirs,

I asked this question in the forum on blackfin.uclinux.org and the gave 
me this email addres to post my mail to.


In drivers/mtd/cmdlinepart.c there is the following piece of code:

if( strncmp(s, "ro", 2) == 0 )
{
 mask_flags |= MTD_WRITEABLE;
s+=2;
}

Is this correct? When the partition is defined to be read-only (ro) the 
MTD_WRITEABLE flag is set? I guess this should be:

if( strncmp(s, "ro", 2) == 0 )
{
 mask_flags &= (~MTD_WRITEABLE); // disable the writeability
s+=2;
}else
{
 mask_flags |= MTD_WRITEABLE; // enable the writeability
}


I hope you can answer my  question. Thanks in advance.

Servaes Joordens
M8


-- 

Servaes Joordens

-------------------------------------------
M8
Tappersweg 29
2031ET	Haarlem
The Netherlands
Tel:	+31 23 5311122
Mob:	+31 6 51183379
Fax:	+31 23 5322388

VAT-ID: nl-813029090B01
kvk:	34131430 Haarlem

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-09-21  9:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-21  7:59 Bug in cmdlinepart.c? M8 (Servaes Joordens)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.